1545554 - Picture-in-Picture toggle should not appear when in fullscreen mode

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Test case

STR:

1. Ensure that Picture-in-Picture is enabled (set media.videocontrols.picture-in-picture.video-toggle.enabled and media.videocontrols.picture-in-picture.enabled to true)

2. Visit the test case

3. Click on the fullscreen button for the video

4. Hover the mouse over the video in fullscreen

ER:

The video should not have a Picture-in-Picture toggle on it.

AR:

The video shows the Picture-in-Picture toggle when hovering it.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1545554 - Hide Picture-in-Picture toggle when in fullscreen mode. r?jaws

Depends on D27002

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1547006 - Add a regression test to ensure that the Picture-in-Picture toggle is not displayed in fullscreen mode. r?jaws

Depends on D28527

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9f0730a57a6
Hide Picture-in-Picture toggle when in fullscreen mode. r=jaws

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c9f0730a57a6

Comment 5

[Phabricator Automation]

Comment on attachment 9060229 [details]
Bug 1547006 - Add a regression test to ensure that the Picture-in-Picture toggle is not displayed in fullscreen mode. r?jaws

Revision D28561 was moved to bug 1547006. Setting attachment 9060229 [details] to obsolete.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

I've spun out the test to bug 1547006, and I'm closing this one out.

Comment 7

[User Dderss]

Bug 1554389 to introduce "media.videocontrols.picture-in-picture.video-toggle.fullscreen.enabled" option.

Comment 8

[Cristian Craciun]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Build ID: 20190527215312

Verified as fixed on Windows 10 with the latest Nightly.