Closed Bug 1545554 Opened 7 months ago Closed 7 months ago

Picture-in-Picture toggle should not appear when in fullscreen mode

Categories

(Toolkit :: Video/Audio Controls, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla68

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Attached file Test case

STR:

  1. Ensure that Picture-in-Picture is enabled (set media.videocontrols.picture-in-picture.video-toggle.enabled and media.videocontrols.picture-in-picture.enabled to true)

  2. Visit the test case

  3. Click on the fullscreen button for the video

  4. Hover the mouse over the video in fullscreen

ER:

The video should not have a Picture-in-Picture toggle on it.

AR:

The video shows the Picture-in-Picture toggle when hovering it.

Attachment #9059342 - Attachment mime type: text/plain → text/html
Assignee: nobody → mconley
Priority: P3 → P1
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9f0730a57a6
Hide Picture-in-Picture toggle when in fullscreen mode. r=jaws
Attachment #9060229 - Attachment description: Bug 1545554 - Add a regression test to ensure that the Picture-in-Picture toggle is not displayed in fullscreen mode. r?jaws → Bug 1547006 - Add a regression test to ensure that the Picture-in-Picture toggle is not displayed in fullscreen mode. r?jaws

Comment on attachment 9060229 [details]
Bug 1547006 - Add a regression test to ensure that the Picture-in-Picture toggle is not displayed in fullscreen mode. r?jaws

Revision D28561 was moved to bug 1547006. Setting attachment 9060229 [details] to obsolete.

Attachment #9060229 - Attachment is obsolete: true

I've spun out the test to bug 1547006, and I'm closing this one out.

Status: NEW → RESOLVED
Closed: 7 months ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Bug 1554389 to introduce "media.videocontrols.picture-in-picture.video-toggle.fullscreen.enabled" option.

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Build ID: 20190527215312

Verified as fixed on Windows 10 with the latest Nightly.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.