1545566 - UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 168: ordinal not in range(128)

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Jason Laster [:jlast]]

I'm seeing this exception when I run DEBUG=1 moz-phab HEAD~1. Here is a link to the output https://drive.google.com/file/d/1sBFYmYcHHCNfA5V-DcNHQeAMedMd-pO_/view?usp=sharing

Comment 1

[André Bargull [:anba]]

I got a similar error when I used moz-phab submit to update an already submitted (and uploaded) phabricator request:

ERROR    2019-07-10 07:04:04,366 Traceback (most recent call last):
  File "/home/andre/bin/moz-phab", line 3769, in main
    args.func(repo, args)
  File "/home/andre/bin/moz-phab", line 3018, in submit
    with temporary_file(message.encode("utf8")) as message_file:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 632: ordinal not in range(128)

The commit message contained the word "µ-benchmarks", which apparently caused this issue, because when I replaced it with "micro-benchmarks", moz-phab completed successfully.

Comment 2

[:glob ✱]

ahh, thanks for the extra info anba.

Comment 3

[:glob ✱]

ERROR    2019-07-10 22:24:51,959 Traceback (most recent call last):
  File "/Users/byron/dev/conduit/review-globau/moz-phab", line 3780, in main
    args.func(repo, args)
  File "/Users/byron/dev/conduit/review-globau/moz-phab", line 3021, in submit
    with temporary_file(message.encode("utf8")) as message_file:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 43: ordinal not in range(128)

Comment 4

[:glob ✱]

Attachment: Bug 1545566 - Fix UnicodeDecodeErrors when commit desc contains non-ascii chars; r=zalun

This change changes all output from hg and git to be unicode encoded.

Comment 5

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/d8e6404e40ca2d3210089096dd6f87a9f1586a23