Closed Bug 1545680 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16368 - Fix flakiness in audioworklet-suspend.https.html

Categories

(Core :: Web Audio, defect, P4)

Product:
Core
Component:
Web Audio
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16368 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16368
Details from upstream follow.

Hongchan Choi <hongchan@chromium.org> wrote:

Fix flakiness in audioworklet-suspend.https.html

It is because the actual suspension takes time to stop the render loop
completely. So the current time advances a little after the suspension
and the assertion that compares two timestamps fails.

This CL fixes the problem by:

  1. Suspend the context immediately after its creation.
  2. Cache timestamp A after the worklet module loading is completed.
  3. Check timestamp B after 500ms. If the context is not suspended
    (which is the original bug), two timestamps A and B won't match.

Bug: 953332
Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html
Change-Id: I3fc4ccf78ec9c137128f8605d502692be303b02e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570129
Reviewed-by: Raymond Toy \<rtoy@chromium.org>
Reviewed-by: Robert Ma \<robertma@chromium.org>
Commit-Queue: Hongchan Choi \<hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651437}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 16368 applied with additional changes from upstream: 81d09351b7bd61a270d58059aba662f17fec536a
Component: web-platform-tests → Web Audio
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdbb5a9c6dc3
[wpt PR 16368] - Fix flakiness in audioworklet-suspend.https.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bdbb5a9c6dc3

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.