Closed Bug 1545758 Opened 4 months ago Closed 4 months ago

Move dom/file IPC components into mozilla::dom namespace.

Categories

(Core :: DOM: File, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(4 files)

No particular reasons. Just consistence with other DOM components.

Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10b380bc5b0c
Move dom/file IPC components into mozilla::dom namespace - FileCreator actors, r=qdot
https://hg.mozilla.org/integration/autoland/rev/d85c68071b54
Move dom/file IPC components into mozilla::dom namespace - PendingIPCBlob actors, r=qdot
https://hg.mozilla.org/integration/autoland/rev/0528f8f11814
Move dom/file IPC components into mozilla::dom namespace - TemporaryIPCBlob actors, r=qdot
https://hg.mozilla.org/integration/autoland/rev/447b0f5a5802
Move dom/file IPC components into mozilla::dom namespace - IPCBlobInputStream actors, r=qdot

Backed out this one because i was getting hunk failed when trying to only backout bug 1534712.
Backed out 5 changesets (Bug 1534712, Bug 1545758) for test_ext_webrequest_upload.html failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=feb8846c6602b5fb4a2580ee1f9155d2fb509585&searchStr=linux%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-linux32%2Fdebug-mochitest-1proc-15%2Cm-1proc%2815%29&tochange=a8478ef589e070357d07e90ff7c0fec2084c41e9

Backout link: https://hg.mozilla.org/integration/autoland/rev/a8478ef589e070357d07e90ff7c0fec2084c41e9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242521854&repo=autoland&lineNumber=6790

[task 2019-04-25T08:34:47.538Z] 08:34:47 INFO - TEST-START | toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html
[task 2019-04-25T08:34:47.620Z] 08:34:47 INFO - GECKO(1637) | ++DOMWINDOW == 113 (0xd6c02000) [pid = 1637] [serial = 877] [outer = 0xdb4a8bd0]
[task 2019-04-25T08:34:47.822Z] 08:34:47 INFO - GECKO(1637) | Console message: Warning: attempting to write 11372 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2019-04-25T08:34:47.863Z] 08:34:47 INFO - GECKO(1637) | ++DOCSHELL 0xd8651000 == 40 [pid = 1637] [id = {1b5ab727-8a27-4c36-b16e-98d91021d82a}]
[task 2019-04-25T08:34:47.865Z] 08:34:47 INFO - GECKO(1637) | ++DOMWINDOW == 114 (0xdbcca010) [pid = 1637] [serial = 878] [outer = (nil)]
[task 2019-04-25T08:34:47.874Z] 08:34:47 INFO - GECKO(1637) | ++DOMWINDOW == 115 (0xda29c800) [pid = 1637] [serial = 879] [outer = 0xdbcca010]
[task 2019-04-25T08:34:47.917Z] 08:34:47 INFO - GECKO(1637) | ++DOMWINDOW == 116 (0xda2a9400) [pid = 1637] [serial = 880] [outer = 0xdbcca010]
[task 2019-04-25T08:34:48.057Z] 08:34:48 INFO - GECKO(1637) | ++DOCSHELL 0xda29d400 == 41 [pid = 1637] [id = {e0851eec-fde0-4b77-b222-abf64e79d788}]
[task 2019-04-25T08:34:48.059Z] 08:34:48 INFO - GECKO(1637) | ++DOMWINDOW == 117 (0xda2f18a0) [pid = 1637] [serial = 881] [outer = (nil)]
[task 2019-04-25T08:34:48.077Z] 08:34:48 INFO - GECKO(1637) | ++DOMWINDOW == 118 (0xda2a0c00) [pid = 1637] [serial = 882] [outer = 0xda2f18a0]
[task 2019-04-25T08:34:48.161Z] 08:34:48 INFO - GECKO(1637) | ++DOMWINDOW == 119 (0xda487c00) [pid = 1637] [serial = 883] [outer = 0xda2f18a0]
[task 2019-04-25T08:34:48.339Z] 08:34:48 INFO - GECKO(1637) | [1637, Socket Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/file/ipc/IPCBlobInputStream.cpp, line 209
[task 2019-04-25T08:34:48.342Z] 08:34:48 INFO - GECKO(1637) | [1637, Socket Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/file/ipc/IPCBlobInputStream.cpp, line 209
[task 2019-04-25T08:34:48.344Z] 08:34:48 INFO - GECKO(1637) | [1637, Socket Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/file/ipc/IPCBlobInputStream.cpp, line 209
[task 2019-04-25T08:34:48.347Z] 08:34:48 INFO - GECKO(1637) | [1637, Socket Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/file/ipc/IPCBlobInputStream.cpp, line 209
[task 2019-04-25T08:34:48.350Z] 08:34:48 INFO - GECKO(1637) | [1637, DOM File] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80470002: file /builds/worker/workspace/build/src/netwerk/base/nsFileStreams.cpp, line 77
[task 2019-04-25T08:34:48.942Z] 08:34:48 INFO - GECKO(1637) | [1637, Socket Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/file/ipc/IPCBlobInputStream.cpp, line 209
...
[task 2019-04-25T08:34:49.495Z] 08:34:49 INFO - GECKO(1637) | runChannelListener@resource://gre/modules/WebRequest.jsm:725:28
[task 2019-04-25T08:34:49.496Z] 08:34:49 INFO - GECKO(1637) | observe@resource://gre/modules/WebRequest.jsm:608:14
[task 2019-04-25T08:34:49.765Z] 08:34:49 INFO - TEST-INFO | started process screentopng
[task 2019-04-25T08:34:50.289Z] 08:34:50 INFO - TEST-INFO | screentopng: exit 0
[task 2019-04-25T08:34:50.289Z] 08:34:50 INFO - Buffered messages logged at 08:34:47
[task 2019-04-25T08:34:50.289Z] 08:34:50 INFO - add_task | Entering test test_setup
[task 2019-04-25T08:34:50.289Z] 08:34:50 INFO - add_task | Leaving test test_setup
[task 2019-04-25T08:34:50.289Z] 08:34:50 INFO - add_task | Entering test test_xhr_forms
[task 2019-04-25T08:34:50.289Z] 08:34:50 INFO - Extension loaded
[task 2019-04-25T08:34:50.289Z] 08:34:50 INFO - Buffered messages logged at 08:34:48
[task 2019-04-25T08:34:50.290Z] 08:34:50 INFO - 629 http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%7D&enctype=multipart%2Fform-data
[task 2019-04-25T08:34:50.290Z] 08:34:50 INFO - onBeforeRequest upload: http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%7D&enctype=multipart%2Fform-data {"formData":{""special" ch�rs":["sp�cial"],"testFile":["testFile.pdf"],"emptyFile":[""],"textInput1":["value1"]}}
[task 2019-04-25T08:34:50.290Z] 08:34:50 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html | Intercepted upload http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%7D&enctype=multipart%2Fform-data #629 {""special" ch�rs":["sp�cial"],"testFile":["testFile.pdf"],"emptyFile":[""],"textInput1":["value1"]} have a requestBody
[task 2019-04-25T08:34:50.290Z] 08:34:50 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html | Upload http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%7D&enctype=multipart%2Fform-data #629 matches form data. - Expected: {""special" ch�rs":["sp�cial"],"testFile":["testFile.pdf"],"emptyFile":[""],"textInput1":["value1"]}, Actual: {""special" ch�rs":["sp�cial"],"testFile":["testFile.pdf"],"emptyFile":[""],"textInput1":["value1"]}
[task 2019-04-25T08:34:50.293Z] 08:34:50 INFO - onCompleted 629 http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%7D&enctype=multipart%2Fform-data
[task 2019-04-25T08:34:50.294Z] 08:34:50 INFO - 630 http://mochi.test:8888/favicon.ico
[task 2019-04-25T08:34:50.296Z] 08:34:50 INFO - onCompleted 630 http://mochi.test:8888/favicon.ico
[task 2019-04-25T08:34:50.297Z] 08:34:50 INFO - Buffered messages logged at 08:34:49
[task 2019-04-25T08:34:50.299Z] 08:34:50 INFO - 631 http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%2C%22blobAsFile%22%3A%5B%22blobAsFile.csv%22%5D%2C%22formDataField%22%3A%5B%22some+value%22%5D%7D&enctype=multipart%2Fform-data&xhr=1
[task 2019-04-25T08:34:50.300Z] 08:34:50 INFO - onBeforeRequest upload: http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%2C%22blobAsFile%22%3A%5B%22blobAsFile.csv%22%5D%2C%22formDataField%22%3A%5B%22some+value%22%5D%7D&enctype=multipart%2Fform-data&xhr=1 {"formData":{""special" ch�rs":["sp�cial"],"testFile":["testFile.pdf"],"emptyFile":[""],"textInput1":["value1"],"blobAsFile":["blobAsFile.csv"],"formDataField":["some value"]}}
[task 2019-04-25T08:34:50.301Z] 08:34:50 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html | Intercepted upload http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%2C%22blobAsFile%22%3A%5B%22blobAsFile.csv%22%5D%2C%22formDataField%22%3A%5B%22some+value%22%5D%7D&enctype=multipart%2Fform-data&xhr=1 #631 {""special" ch�rs":["sp�cial"],"testFile":["testFile.pdf"],"emptyFile":[""],"textInput1":["value1"],"blobAsFile":["blobAsFile.csv"],"formDataField":["some value"]} have a requestBody
[task 2019-04-25T08:34:50.302Z] 08:34:50 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html | Upload http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%2C%22blobAsFile%22%3A%5B%22blobAsFile.csv%22%5D%2C%22formDataField%22%3A%5B%22some+value%22%5D%7D&enctype=multipart%2Fform-data&xhr=1 #631 matches form data. - Expected: {""special" ch�rs":["sp�cial"],"testFile":["testFile.pdf"],"emptyFile":[""],"textInput1":["value1"],"blobAsFile":["blobAsFile.csv"],"formDataField":["some value"]}, Actual: {""special" ch�rs":["sp�cial"],"testFile":["testFile.pdf"],"emptyFile":[""],"textInput1":["value1"],"blobAsFile":["blobAsFile.csv"],"formDataField":["some value"]}
[task 2019-04-25T08:34:50.304Z] 08:34:50 INFO - onCompleted 631 http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%7B%22%5C%22special%5C%22+ch%EF%BF%BDrs%22%3A%5B%22sp%EF%BF%BDcial%22%5D%2C%22testFile%22%3A%5B%22testFile.pdf%22%5D%2C%22emptyFile%22%3A%5B%22%22%5D%2C%22textInput1%22%3A%5B%22value1%22%5D%2C%22blobAsFile%22%3A%5B%22blobAsFile.csv%22%5D%2C%22formDataField%22%3A%5B%22some+value%22%5D%7D&enctype=multipart%2Fform-data&xhr=1
[task 2019-04-25T08:34:50.305Z] 08:34:50 INFO - 632 http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%5B%7B%22file%22%3A%22%3Cfile%3E%22%7D%5D&enctype=multipart%2Fform-data&xhr=1
[task 2019-04-25T08:34:50.306Z] 08:34:50 INFO - onBeforeRequest upload: http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%5B%7B%22file%22%3A%22%3Cfile%3E%22%7D%5D&enctype=multipart%2Fform-data&xhr=1 {"error":"Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIBinaryInputStream.available]"}
[task 2019-04-25T08:34:50.307Z] 08:34:50 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html | Intercepted upload http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%5B%7B%22file%22%3A%22%3Cfile%3E%22%7D%5D&enctype=multipart%2Fform-data&xhr=1 #632 [{"file":"<file>"}] have a requestBody
[task 2019-04-25T08:34:50.307Z] 08:34:50 INFO - Buffered messages finished
[task 2019-04-25T08:34:50.309Z] 08:34:50 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html | Upload http://mochi.test:8888/tests/toolkit/components/extensions/test/mochitest/file_WebRequest_page3.html?trigger=form&upload=%5B%7B%22file%22%3A%22%3Cfile%3E%22%7D%5D&enctype=multipart%2Fform-data&xhr=1 #632 matches form data. - Expected: [{"file":"<file>"}], Actual: undefined
[task 2019-04-25T08:34:50.310Z] 08:34:50 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-04-25T08:34:50.311Z] 08:34:50 INFO - testHandler@SimpleTest/ExtensionTestUtils.js:59:18

Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e21b536f288
Move dom/file IPC components into mozilla::dom namespace - FileCreator actors, r=qdot
https://hg.mozilla.org/integration/autoland/rev/9e87f6fa89b7
Move dom/file IPC components into mozilla::dom namespace - PendingIPCBlob actors, r=qdot
https://hg.mozilla.org/integration/autoland/rev/46448e3d9185
Move dom/file IPC components into mozilla::dom namespace - TemporaryIPCBlob actors, r=qdot
https://hg.mozilla.org/integration/autoland/rev/ffd5b4fd36a5
Move dom/file IPC components into mozilla::dom namespace - IPCBlobInputStream actors, r=qdot
You need to log in before you can comment on or make changes to this bug.