1545765 - The background color for the primary button on popupnotifications is no longer blue

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: CFR button wrong background.gif

[Affected versions]:

• Firefox Nightly 68.0a1, Build ID 20190419094745

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to true in the "about:config" page.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the "about:newtab#asrouter" page and scroll down to the "FACEBOOK_CONTAINER_3" section.
3. Click the "Show" button and click the "CFR Recommendation" button from the right part of the "Address Bar".
4. Observe the background of the "Add Now" button.

[Expected result]:

• The button's background is blue.

[Actual result]:

• All the buttons from the bottom part of the CFR doorhanger have the same grey background.

[Regression window]:

• Considering the fact that this issue is not reproducible with the Firefox Nightly version from 04/18/2019, using the "Mozregression" tool, I have managed to find a regression window:

Last good revision: 27157cc6395ef681545b5a8ae5f95fc584f38792
First bad revision: 223a8a0c4eed19547e6e843cfd265c728f7dc7c2
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=27157cc6395ef681545b5a8ae5f95fc584f38792&tochange=223a8a0c4eed19547e6e843cfd265c728f7dc7c2

[Notes]:

• This issue is also reproducible with the "Pin This Tab" CFR button.
• Attached a screen recording of the issue.

Comment 1

[Marius Coman [:mcoman], Ecosystem QA]

Hi Brian, could you please give us your opinion regarding this issue?

Comment 2

[Brian Grinstead [:bgrins]]

This looks like a popup notification issue that was most likely regressed by Bug 1528268. I'll look into this as soon as I address a more visible menu-related regression from the same push.

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

Thank you, Brian!

Comment 4

[Brian Grinstead [:bgrins]]

This looks like a more general issue - I'm seeing it on the location prompt as well.

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: location-prompt.png

Comment 6

[Brian Grinstead [:bgrins]]

The default="true" attribute isn't getting copied onto the button (https://searchfox.org/mozilla-central/rev/966590c35c19d3b7850c5444a31bf0fd68a7d0c4/toolkit/content/widgets/popupnotification.js#29)

Comment 7

[Brian Grinstead [:bgrins]]

Attachment: before-change.png

So without the patch we were copying over the empty [buttonhighlight] attr on the host element onto the button.

Comment 8

[Brian Grinstead [:bgrins]]

Attachment: Bug 1545765 - Fix attribute inheritance for empty attribute values

This accidentally got dropped in Bug 1528268.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9e14c54335a
Fix attribute inheritance for empty attribute values r=aswan

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c9e14c54335a

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (68.0b4 Build ID - 20190523115432) and latest Firefox Nightly (69.0a1 Build ID - 20190523115432) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the background color for the primary button is blue.