Closed Bug 1545865 Opened 5 years ago Closed 5 years ago

Make inheritedAttributes work when overridden in derived classes

Categories

(Toolkit :: UI Widgets, enhancement)

60 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: aswan, Assigned: aswan)

References

Details

Attachments

(1 file)

The existing implementation of inherited attributes keeps a data structure in a property on the class, but derived classes get that structure from their parent class, which prevents derived classes from declaring a different set of inherited
attributes.

The existing implementation of inherited attributes keeps a data
structure in a property on the class, but derived classes were
unintentionally getting that structure from their parent class,
preventing derived classes from declaring a different set of inherited
attributes.

There's quite a bit of orange here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4afc048441fbcc804e22323b7a31df51262560ca

But it all appears to be existing unrelated intermittents.

Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/581755bf8899
Handle inherited attributes overridden by derived element classes r=bgrins
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: