Make inheritedAttributes work when overridden in derived classes

RESOLVED FIXED in Firefox 68

Status

()

enhancement
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: aswan, Assigned: aswan)

Tracking

(Blocks 1 bug)

60 Branch
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a month ago

The existing implementation of inherited attributes keeps a data structure in a property on the class, but derived classes get that structure from their parent class, which prevents derived classes from declaring a different set of inherited
attributes.

Assignee

Comment 1

a month ago

The existing implementation of inherited attributes keeps a data
structure in a property on the class, but derived classes were
unintentionally getting that structure from their parent class,
preventing derived classes from declaring a different set of inherited
attributes.

Assignee

Comment 2

a month ago

There's quite a bit of orange here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4afc048441fbcc804e22323b7a31df51262560ca

But it all appears to be existing unrelated intermittents.

Comment 3

a month ago
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/581755bf8899
Handle inherited attributes overridden by derived element classes r=bgrins

Comment 4

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.