1546003 - [markup view] Linkify ARIA attributes

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Takeshi Kurosawa :takenspc]

The inspector's markup view doesn't support clicking id references in ARIA attributes such as aria-labelledby and aria-controls while for attribute of label element is supported.

Considering wide usage of ARIA we should support ARIA attributes in the markup view.

According to WAI-ARIA 1.1 spec, following attributes reference other elementS.

• aria-activedescendant
• aria-controls
• aria-describedby
• aria-details
• aria-errormessage
• aria-flowto
• aria-labelledby
• aria-owns

Comment 1

[Takeshi Kurosawa :takenspc]

Attachment: Bug 1546003 - [markup view] Linkify ARIA attributes. r?gl

Add support to likify ARIA attributes which reference other elements.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:takenspc, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Patrick Brosset <:pbro>]

Gabriel, this bug seems to be paused in a landable state. Do you mind looking at your review again, checking that it still applies, and attempting to land this?

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Patrick Brosset <:pbro> from comment #3)

Gabriel, this bug seems to be paused in a landable state. Do you mind looking at your review again, checking that it still applies, and attempting to land this?

The current patch will need a rebase, and maybe another re-review. I will assign myself and take over the revision in the meantime.

Comment 5

[Takeshi Kurosawa :takenspc]

Attachment: Bug 1546003 - [markup view] Linkify ARIA attributes. r=nchevobbe

Add support to likify ARIA attributes which reference other elements.

Comment 6

[Takeshi Kurosawa :takenspc]

Comment on attachment 9059711 [details]
Bug 1546003 - [markup view] Linkify ARIA attributes. r?gl

I am so sorry not responding for a long time. I updated the patch and obsolete this one.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b544a2a99919
[markup view] Linkify ARIA attributes. r=devtools-reviewers,nchevobbe

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_markup_links_aria_attributes.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/44a65eeab0b4f4072824131578fe480b58055765
Log link: https://treeherder.mozilla.org/logviewer?job_id=425531864&repo=autoland&lineNumber=21453

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a631bcc47f8
[markup view] Linkify ARIA attributes. r=devtools-reviewers,nchevobbe

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6a631bcc47f8