snap area should contain scroll-margin areas

RESOLVED FIXED in Firefox 68

Status

()

defect
P2
normal
RESOLVED FIXED
28 days ago
22 days ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

28 days ago

I had misunderstand that visible area doesn't contain scroll-margin areas, but it has to have the ares.

https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-area

Values represent outsets defining the scroll snap area that is used for snapping this box to the snapport. The scroll snap area is determined by taking the transformed border box, finding its rectangular bounding box (axis-aligned in the scroll container’s coordinate space), then adding the specified outsets.

The Values here are scroll-margin properties' values.

This is one of the reasons why the example in bug 1531589 comment 2 doesn't work.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=103b390140a8292719fd8a3a471e0425e3c25a7d

(Assignee)

Comment 1

28 days ago

This patch also renames targetRect to snapArea to represent it more
accurately.

Comment 2

28 days ago

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)

Oh thank you, for both looking into and filing this!

Side note, could this have any relation to another bug I also filed?
https://bugzilla.mozilla.org/show_bug.cgi?id=1545316

Comment 3

27 days ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f0320a85555
Include scroll-margin areas into snap area. r=botond

Comment 4

26 days ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 26 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16492 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.