Closed Bug 1546038 Opened 2 years ago Closed 1 year ago

snap area should contain scroll-margin areas

Categories

(Core :: Layout: Scrolling and Overflow, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I had misunderstand that visible area doesn't contain scroll-margin areas, but it has to have the ares.

https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-area

Values represent outsets defining the scroll snap area that is used for snapping this box to the snapport. The scroll snap area is determined by taking the transformed border box, finding its rectangular bounding box (axis-aligned in the scroll container’s coordinate space), then adding the specified outsets.

The Values here are scroll-margin properties' values.

This is one of the reasons why the example in bug 1531589 comment 2 doesn't work.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=103b390140a8292719fd8a3a471e0425e3c25a7d

This patch also renames targetRect to snapArea to represent it more
accurately.

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)

Oh thank you, for both looking into and filing this!

Side note, could this have any relation to another bug I also filed?
https://bugzilla.mozilla.org/show_bug.cgi?id=1545316

Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f0320a85555
Include scroll-margin areas into snap area. r=botond
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16492 for changes under testing/web-platform/tests
You need to log in before you can comment on or make changes to this bug.