Closed
Bug 1546048
Opened 6 years ago
Closed 6 years ago
Use the cstr crate instead of the macro added in bug 1542528
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
|
Bug 1546048 - Use std::ffi::CStr and the cstr crate instead of custom stuff in xpcom. r=lina,froydnj
47 bytes,
text/x-phabricator-request
|
Details | Review |
In bug 1542528, a new c_str macro was added. Xidorn maintains the cstr crate which we use in the style system.
We should use that instead rather than having two implementations, probably.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → emilio
|
|
Assignee | |
Comment 1•6 years ago
|
||
Also, this checks for strings with nulls, which is nice (though I guess an
uncommon mistake).
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43c7c3f10a71
Use std::ffi::CStr and the cstr crate instead of custom stuff in xpcom. r=lina
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•