1546109 - Replace references to generatedLocation in the server

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P5)

Description

[Jason Laster [:jlast]]

There are plenty of places in the server where the terms (generatedLocation, generatedLine, generatedColumn, ...) are used. We can replace these with (location, line, column, ...)

• generatedLocation
• generatedColumn

For historical context. We have this because the server used to support source maps.

I started this here a couple of months ago.

Comment 2

[Kevin Morehouse]

@Jason, I'd be happy to take this.

Looking at your comment and the gist posted above, I've searched through the files, and it seems that the relevant changes to be made are:

• Replace:
  • generatedSourceActor —> sourceActor
  • generatedLine —> line
  • generatedColumn —> column
  • generatedLastColumn —> lastColumn
  • generatedUrl —> url
• Replace any references in comments to match the above changes.

The affected files are:

• devtools/server/actors/breakpoint.js
• devtools/server/actors/common.js
• devtools/server/actors/frame.js
• devtools/server/actors/thread.js
• devtools/server/actors/utils/TabSources.js

Is there anything else I should look at in order to complete this task properly?

Comment 3

[Kevin Morehouse]

Attachment: Bug 1546109 - Replace references to generated properties in the server

Replace:
generatedSourceActor —> sourceActor
generatedLine —> line
generatedColumn —> column
generatedLastColumn —> lastColumn
generatedUrl —> url
generatedLocation -> location
GeneratedLocation -> SourceLocation
parentGeneratedLocation -> parentLocation
Replace references in comments to match the above changes.

The affected files are:

devtools/server/actors/breakpoint.js
devtools/server/actors/common.js
devtools/server/actors/frame.js
devtools/server/actors/thread.js
devtools/server/actors/utils/TabSources.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2be65d281b2
Replace references to generated properties in the server r=jlast

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e2be65d281b2