Replace references to generatedLocation in the server

RESOLVED FIXED in Firefox 69

Status

task
P5
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: jlast, Assigned: khmorehouse)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
Firefox 69
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

There are plenty of places in the server where the terms (generatedLocation, generatedLine, generatedColumn, ...) are used. We can replace these with (location, line, column, ...)

For historical context. We have this because the server used to support source maps.

I started this here a couple of months ago.

Blocks: dbg-server
Type: defect → task
Keywords: good-first-bug
Duplicate of this bug: 1517514
Priority: -- → P5

@Jason, I'd be happy to take this.

Looking at your comment and the gist posted above, I've searched through the files, and it seems that the relevant changes to be made are:

  • Replace:
    • generatedSourceActor —> sourceActor
    • generatedLine —> line
    • generatedColumn —> column
    • generatedLastColumn —> lastColumn
    • generatedUrl —> url
  • Replace any references in comments to match the above changes.

The affected files are:

  • devtools/server/actors/breakpoint.js
  • devtools/server/actors/common.js
  • devtools/server/actors/frame.js
  • devtools/server/actors/thread.js
  • devtools/server/actors/utils/TabSources.js

Is there anything else I should look at in order to complete this task properly?

Assignee: nobody → khmorehouse

Replace:
generatedSourceActor —> sourceActor
generatedLine —> line
generatedColumn —> column
generatedLastColumn —> lastColumn
generatedUrl —> url
generatedLocation -> location
GeneratedLocation -> SourceLocation
parentGeneratedLocation -> parentLocation
Replace references in comments to match the above changes.

The affected files are:

devtools/server/actors/breakpoint.js
devtools/server/actors/common.js
devtools/server/actors/frame.js
devtools/server/actors/thread.js
devtools/server/actors/utils/TabSources.js
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2be65d281b2
Replace references to generated properties in the server r=jlast
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.