Closed Bug 1546135 Opened 7 months ago Closed 7 months ago

WebExtension constructor should take a flags argument

Categories

(GeckoView :: General, task, P3)

Unspecified
All

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: Agi, Assigned: Agi)

Details

Attachments

(1 file)

Right now we use a boolean for allowContentMessaging. We should use a flag instead to make the code more explicit:

WebExtension("resource://android/assets/messaging/", "messaging", true)

would become

WebExtension("resource://android/assets/messaging/", "messaging",
     WebExtension.Flags.ALLOW_CONTENT_MESSAGING)
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a322ec5c25e6
[geckoview] Use flags in WebExtension constructor. r=esawin,snorp
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87acb99ad649
[geckoview] Use flags in WebExtension constructor. r=esawin,snorp
Flags: needinfo?(agi)
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.