Closed
Bug 1546135
Opened 5 years ago
Closed 5 years ago
WebExtension constructor should take a flags argument
Categories
(GeckoView :: Extensions, task, P3)
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: agi, Assigned: agi)
Details
Attachments
(1 file)
Right now we use a boolean for allowContentMessaging. We should use a flag instead to make the code more explicit:
WebExtension("resource://android/assets/messaging/", "messaging", true)
would become
WebExtension("resource://android/assets/messaging/", "messaging",
WebExtension.Flags.ALLOW_CONTENT_MESSAGING)
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a322ec5c25e6 [geckoview] Use flags in WebExtension constructor. r=esawin,snorp
|
||
Comment 3•5 years ago
|
||
Backed out for build bustages.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1546411#c5
Backout: https://hg.mozilla.org/integration/autoland/rev/358171d00f9a1251fff6269ca343fbe9e8ece858
Flags: needinfo?(agi)
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87acb99ad649 [geckoview] Use flags in WebExtension constructor. r=esawin,snorp
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(agi)
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Comment 6•2 years ago
|
||
Moving some WebExtension bugs to the GeckoView::Extensions component.
Component: General → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•