1546153 - crash in NullPointerException at org.mozilla.gecko.BrowserApp.onCreate(BrowserApp.java) on null mBrowserToolbar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Chris Peterson [:cpeterson]]

We should try to fix bug for [bcs:p2] because it's related to system language settings. Probably not a [bcs:p1] because users are unlikely to change their system language settings very often.

STR:

1. Open Fennec. I was testing Fennec 66 Release.
2. Go to Android's system settings and change the system language: System > Languages & input > Languages.
3. Switch back to Fennec.

EXPECTED RESULT:
Fennec's UI language should change.

ACTUAL RESULT:
Fennec will sometimes crash.

I was able to twice reproduce a similar NullPointerException at org.mozilla.gecko.BrowserApp.onCreate(BrowserApp.java) after switching my Android system language settings.

bp-de0b3b1b-ac94-4f7c-a7c2-eda9d0190422

Looks like mBrowserToolbar is null here: https://searchfox.org/mozilla-release/rev/ee65ae17d964dda4d764020b2f0c0a09c6cd1984/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#651

java.lang.NullPointerException
	at org.mozilla.gecko.BrowserApp.onCreate(BrowserApp.java:651)
	at android.app.Activity.performCreate(Activity.java:7032)
	at android.app.Activity.performCreate(Activity.java:7023)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1236)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2814)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2943)
	at android.app.ActivityThread.-wrap11(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1630)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6626)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811)

Comment 1

[Mira Lobontiu (Android QA)]

Attachment: 2019_04_23_15_58_51.mp4

Hi all,

I was able to reproduce the issue on the latest Nightly 68.0a1 (2019-04-23), on Beta 67.0b13, and on RC 66.0.2 on Samsung Galaxy Note 8 (Android 9).
I got a crash report only on RC, while Nightly and Beta crashed without a report, like in the attached short video.

Thank you!

Comment 2

[Chris Peterson [:cpeterson]]

This crash volume is a lot higher than I would expect. Perhaps this crash signature can be triggered by multiple causes.

Comment 3

[Anuta Logigan]

We were able to reproduce this using the steps above but only with the "Don't keep activities" enabled from the Developer options. I will prepare a PR with the fix.

Comment 4

[Anuta Logigan]

Attachment: Bug 1546153 - <Fixed NPE at BrowserApp.onCreate() caused by mBrowserToolbar being null>; <VladBaicu>

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It's currently not possible to land this, the landing system blocks it with this message:

'Lando says "This diff does not have the proper author information uploaded to Phabricator", but I see an author on Phabricator. What's wrong?'

See https://wiki.mozilla.org/Phabricator/FAQ#Lando

There is no previous, recent commit by Anuta found in mozilla-central, so I haven't the information (what user name and email address shall be used) to land this manually.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa5584298300
Fix NPE at BrowserApp.onCreate() caused by mBrowserToolbar being null. r=VladBaicu

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a2d4ae3d07f
Backed out changeset fa5584298300 for checkstyle failure (missing whitespace)
https://hg.mozilla.org/integration/autoland/rev/86c7622bc218
Fix NPE at BrowserApp.onCreate() caused by mBrowserToolbar being null. r=VladBaicu

Comment 8

[Chris Peterson [:cpeterson]]

67=wontfix because it's too late to uplift to Fennec 67 Beta. We've had this crash for a long time, so the fix can ride the trains with Fennec 68.

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/86c7622bc218

Comment 10

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Nightly 68.0a1 (2019-05-05), with Samsung Galaxy Note 8 (Android 9), Nexus 6P (Android 8.1.0), and Nexus 5 (Android 6.0.1).