Move "text" out of Source object into a standalone field alongside Source

RESOLVED FIXED in Firefox 68

Status

task
P2
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

Tracking

(Blocks 2 bugs)

Trunk
Firefox 68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(6 attachments)

The loaded Source text is currently stored inside of the Source object, which complicates a bunch of things and increases the amount of mutation happening to source objects.

We want to move the "text" into a separate field outside the Source object to avoid that, so we need to update all the places where source text is used to pull the new field out of the Redux store.

Type: defect → task
No longer blocks: 1541638
Blocks: 1541638
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c38471c164e
Part 1: Remove unused getFramwwork and hasSource functions. r=jlast
https://hg.mozilla.org/integration/autoland/rev/d99fa29130d5
Part 2: Change parser worker to work with a trimmed-down AstSource instead of the full Source. r=jlast
https://hg.mozilla.org/integration/autoland/rev/800d67478a31
Part 3: Remove the isLoading utility function. r=jlast
https://hg.mozilla.org/integration/autoland/rev/ed79e89eea8d
Part 4: Allow Blackboxing before text is loaded. r=jlast
https://hg.mozilla.org/integration/autoland/rev/55ac8a74ae58
Part 5: Add a new selector to handle both Source and SourceContent datatypes. r=jlast
https://hg.mozilla.org/integration/autoland/rev/f81c7ca6d292
Part 6: Delete the old Source object text value fields to switch fully to SourceContent. r=jlast
You need to log in before you can comment on or make changes to this bug.