1546202 - Move "text" out of Source object into a standalone field alongside Source

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P2)

Description

[Logan Smyth [:loganfsmyth]]

The loaded Source text is currently stored inside of the Source object, which complicates a bunch of things and increases the amount of mutation happening to source objects.

We want to move the "text" into a separate field outside the Source object to avoid that, so we need to update all the places where source text is used to pull the new field out of the Redux store.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1546202 - Part 1: Remove unused getFramwwork and hasSource functions. r=jlast

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1546202 - Part 2: Change parser worker to work with a trimmed-down AstSource instead of the full Source. r=jlast

Depends on D28408

Comment 3

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1546202 - Part 3: Remove the isLoading utility function. r=jlast

Depends on D28409

Comment 4

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1546202 - Part 4: Allow Blackboxing before text is loaded. r=jlast

Depends on D28410

Comment 5

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1546202 - Part 5: Add a new selector to handle both Source and SourceContent datatypes. r=jlast

Depends on D28411

Comment 6

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1546202 - Part 6: Delete the old Source object text value fields to switch fully to SourceContent. r=jlast

Depends on D28412

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c38471c164e
Part 1: Remove unused getFramwwork and hasSource functions. r=jlast
https://hg.mozilla.org/integration/autoland/rev/d99fa29130d5
Part 2: Change parser worker to work with a trimmed-down AstSource instead of the full Source. r=jlast
https://hg.mozilla.org/integration/autoland/rev/800d67478a31
Part 3: Remove the isLoading utility function. r=jlast
https://hg.mozilla.org/integration/autoland/rev/ed79e89eea8d
Part 4: Allow Blackboxing before text is loaded. r=jlast
https://hg.mozilla.org/integration/autoland/rev/55ac8a74ae58
Part 5: Add a new selector to handle both Source and SourceContent datatypes. r=jlast
https://hg.mozilla.org/integration/autoland/rev/f81c7ca6d292
Part 6: Delete the old Source object text value fields to switch fully to SourceContent. r=jlast

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1c38471c164e
https://hg.mozilla.org/mozilla-central/rev/d99fa29130d5
https://hg.mozilla.org/mozilla-central/rev/800d67478a31
https://hg.mozilla.org/mozilla-central/rev/ed79e89eea8d
https://hg.mozilla.org/mozilla-central/rev/55ac8a74ae58
https://hg.mozilla.org/mozilla-central/rev/f81c7ca6d292