1546324 - Crash in [@ static class mozilla::media::TimeUnit mozilla::media::operator%]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-de3a5325-6922-4992-86e1-04f2d0190422.

Top 10 frames of crashing thread:

0 xul.dll static class mozilla::media::TimeUnit mozilla::media::operator% dom/media/TimeUnits.h:168
1 xul.dll void mozilla::MediaDecoderStateMachine::AdjustByLooping dom/media/MediaDecoderStateMachine.cpp:3925
2 xul.dll void mozilla::MediaDecoderStateMachine::UpdatePlaybackPositionPeriodically dom/media/MediaDecoderStateMachine.cpp:3412
3 xul.dll void mozilla::MediaDecoderStateMachine::DecodingState::Step dom/media/MediaDecoderStateMachine.cpp:2330
4 xul.dll void mozilla::MozPromise<bool, bool, 1>::ThenValue<`lambda at z:/task_1555926966/build/src/dom/media/MediaDecoderStateMachine.cpp:3478:7', `lambda at z:/task_1555926966/build/src/dom/media/MediaDecoderStateMachine.cpp:3482:7'>::DoResolveOrRejectInternal xpcom/threads/MozPromise.h:717
5 xul.dll mozilla::MozPromise<bool, bool, 1>::ThenValueBase::ResolveOrRejectRunnable::Run xpcom/threads/MozPromise.h:393
6 xul.dll nsresult mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:199
7 xul.dll nsresult nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:244
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1180
9 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486

There is 1 crash in nightly 68 with buildid 20190422094240. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1544150.

[1] https://hg.mozilla.org/mozilla-central/rev?node=2b5c64a994b3

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1546324 - use TimeUnit version modular.

The value of mAudioDecodedDuration can be larger than int32, so we should use the modular function which accepts TimeUnitas a input.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c7736806fe0
use TimeUnit version modular. r=bryce

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1c7736806fe0