Closed Bug 1546344 Opened 5 years ago Closed 4 years ago

Refactor nsSHEntry

Categories

(Core :: DOM: Navigation, task, P3)

Product:
Core
Component:
DOM: Navigation
Type:
task

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox68 --- affected

People

(Reporter: peterv, Unassigned)

References

(Blocks 1 open bug)

Details

Bug 1438272 adds two class that inherit from nsSHEntry: nsLegacySHEntry and mozilla::dom::LegacySHEntry. The first is only used for implementing the entries for session history that entirely located within the parent process. The second is used for the entry parent IPC actor. Ideally the second usage would not go through nsISHEntry, and nsSHEntry would just implement the necessary methods that are common to both (see all the MOZ_CRASH annotations in nsSHEntry, all in methods that are only used from nsLegacySHEntry).

Blocks: fission-history
Type: enhancement → task
Priority: -- → P3

Interpretation is that this was for the previous approach, and shouldn't be needed anymore, given that there are no
*LegacySHEntry anymore.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.