1546350 - Reimplement history listeners for session history living in the parent process

Status: RESOLVED DUPLICATE of bug 1507287

(Core :: DOM: Navigation, task, P3)

Description

[Peter Van der Beken [:peterv]]

Bug 1438272 didn't implement session history listeners for remote session history living in the parent process.

Comment 1

[Neha Kochar [:neha]]

There are probably still some session history listeners in sessionStore that need to be fixed.

Comment 2

[Alphan Chen [:alchen]]

Here are session history listeners used when enabling session history in the parent.
https://searchfox.org/mozilla-central/rev/72a1334982cadde0ca8b3d3583877afea80f5639/browser/components/sessionstore/SessionStore.jsm#991,1120

So we need corresponding changes when there are changes in nsISHistoryListener interface.
https://searchfox.org/mozilla-central/rev/72a1334982cadde0ca8b3d3583877afea80f5639/docshell/shistory/nsISHistoryListener.idl#27

Comment 3

[Peter Van der Beken [:peterv]]

Hi Alphan, does that mean that all session history listeners for session store are fixed to work with session history in the parent? I seem to remember that the one in browser/components/sessionstore/ContentSessionStore.jsm is only used when session history in the parent is not enabled? What about the ones in browser/components/sessionstore/ContentRestore.jsm? If all of these are fixed for session history in the parent already then I think we can just close this bug as a dupe of bug 1507287.

Comment 4

[Alphan Chen [:alchen]]

I don't remember there is anything left.
The session history listeners in ContentSessionStore.jsm and ContentRestore.jsm are only used when the pref is off.
We can remove those listeners when we only have the session history in the parent process.

Comment 5

[Peter Van der Beken [:peterv]]

Ok, great. Let's dupe this for now. We can always open a new bug if there's work remaining to be done that we overlooked.

Comment 6

[Chris Peterson [:cpeterson]]

Clearing Fission Milestone for bugs resolved as duplicates. We don't need to track duplicates.