1546413 - #positionLabel and #durationLabel seem like dead elements since bug 1444489

Status: NEW

(Toolkit :: Video/Audio Controls, task, P3)

Description

[Ian Moody [:Kwan] (UTC+0)]

Discovered in https://phabricator.services.mozilla.com/D27757

It seems like https://hg.mozilla.org/mozilla-central/rev/e0c831e58530 (bug 1444489) removed any code that set their contents, but left the elements themselves behind in the videocontrols binding (and they've survived through to the custom element version). The actual position and duration text is instead placed inside the #positionDurationBox element.

What needs doing:

Removing the elements themselves:

https://searchfox.org/mozilla-central/rev/f46e2bf881d522a440b30cbf5cf8d76fc212eaf4/toolkit/content/widgets/videocontrols.js#2299-2300

Removing stored references to them:

https://searchfox.org/mozilla-central/rev/f46e2bf881d522a440b30cbf5cf8d76fc212eaf4/toolkit/content/widgets/videocontrols.js#115-116
https://searchfox.org/mozilla-central/rev/f46e2bf881d522a440b30cbf5cf8d76fc212eaf4/toolkit/content/widgets/videocontrols.js#1985-1986

Remove the last bit of CSS that refers to them:

https://searchfox.org/mozilla-central/rev/f46e2bf881d522a440b30cbf5cf8d76fc212eaf4/toolkit/themes/shared/media/videocontrols.css#375-378

Remove test references:

https://searchfox.org/mozilla-central/rev/f46e2bf881d522a440b30cbf5cf8d76fc212eaf4/toolkit/content/tests/widgets/test_videocontrols_size.html#82,96

Double check there are no more references that need removing:
https://searchfox.org/mozilla-central/search?q=durationLabel&case=true&regexp=false&path=
https://searchfox.org/mozilla-central/search?q=positionLabel&case=true&regexp=false&path=

(anything under the devtools/ folder is about a different element)