1546439 - Bump Cranelift and allow to print optimized IR from within Spidermonkey

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

The print patch allows one to do the following:

RUST_LOG=baldrdash::compile=debug ./dist/bin/js --wasm-compiler=cranelift /tmp/a.js

where a.js is wasm + JS glue code.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

(Note the Cranelift bump is interesting because this is a perf improvement, and an opportunity to see if AWFY will show it, namely on Embenchen branches sub-test.)

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1546439: Bump Cranelift to 538a0662bf90a1daa9921c10f34827ace134abf1; r?lth

The one optimization introduced by this is the rearrangement of branches to
prefer fallthrough whenever possible, as well as folding branches when
comparing against 0. See also
https://github.com/CraneStation/cranelift/pull/629 for details.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1546439: Allow showing the optimized IR of a Cranelift-compiled function; r?lth

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5acf68edbf59
Bump Cranelift to 538a0662bf90a1daa9921c10f34827ace134abf1; r=lth
https://hg.mozilla.org/integration/autoland/rev/8c14162a3f8e
Allow showing the optimized IR of a Cranelift-compiled function; r=lth

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1546439) for build bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=8c14162a3f8e184416f850e0d4ef081ef2328a69&selectedJob=242251119

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242251160&repo=autoland&lineNumber=2768

Backout: https://hg.mozilla.org/integration/autoland/rev/36e49a036a2e7010667bf7f60111b48b25470e58

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1546439: Cranelift: move platform-specific opcodes checks into a platform-specific function; r?lth

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df4c4083aff8
Bump Cranelift to 538a0662bf90a1daa9921c10f34827ace134abf1; r=lth
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fd6e9df0a2c
Allow showing the optimized IR of a Cranelift-compiled function; r=lth

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/df4c4083aff8
https://hg.mozilla.org/mozilla-central/rev/5fd6e9df0a2c