1546482 - browser_editcontrols_update.js fails when run outside of the mochitest-clipboard job

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

you can see the failures here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ba44c5d9157a02c97ff3618d8e5c4a101fa1694&searchStr=browser-chrome

and from the win10/opt log:
20:54:11 INFO - TEST-PASS | browser/components/customizableui/test/browser_editcontrols_update.js | Update when edit-controls is on palette, hidden and selection changed - cut -
20:54:11 INFO - TEST-PASS | browser/components/customizableui/test/browser_editcontrols_update.js | Update when edit-controls is on palette, hidden and selection changed - paste -
20:54:11 INFO - Leaving test bound test_panelui_customize_to_palette
20:54:11 INFO - Entering test bound finish
20:54:11 INFO - Leaving test bound finish
20:54:11 INFO - Entering test bound test_initial_state
20:54:11 INFO - Console message: [JavaScript Error: "TypeError: aToolbar is null" {file: "resource:///modules/CustomizableUI.jsm" line: 748}]
20:54:11 INFO - registerToolbarNode@resource:///modules/CustomizableUI.jsm:748:16
20:54:11 INFO - registerToolbarNode@resource:///modules/CustomizableUI.jsm:3210:28
20:54:11 INFO - onDOMContentLoaded@chrome://browser/content/browser.js:1444:22
20:54:11 INFO - EventListener.handleEvent*@chrome://browser/content/browser.xul:113:10
20:54:11 INFO -
20:54:11 INFO - Buffered messages finished
20:54:11 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_editcontrols_update.js | Uncaught exception - undefined - timed out after 50 tries.
20:54:11 INFO - Leaving test bound test_initial_state
20:54:11 INFO - GECKO(6316) | MEMORY STAT | vsize 2104348MB | vsizeMaxContiguous 65420043MB | residentFast 394MB | heapAllocated 118MB
20:54:11 INFO - TEST-OK | browser/components/customizableui/test/browser_editcontrols_update.js | took 7164ms
20:54:11 INFO - checking window state
20:54:11 INFO - Not taking screenshot here: see the one that was previously logged
20:54:11 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_editcontrols_update.js | Found an unexpected browser window at the end of test run -
20:54:11 INFO - GECKO(6316) | must wait for focus
20:54:11 INFO - TEST-START | browser/components/customizableui/test/browser_exit_background_customize_mode.js
20:54:12 INFO - GECKO(6316) | MEMORY STAT | vsize 2104339MB | vsizeMaxContiguous 65420043MB | residentFast 389MB | heapAllocated 124MB
20:54:12 INFO - TEST-OK | browser/components/customizableui/test/browser_exit_background_customize_mode.js | took 985ms

I see 4 related intermittent bugs (bug 1503204, bug 1422564, bug 1409189, and bug 1396196), not sure if the could be fixed up as well.

as we are looking to get rid of the custom clipboard job as it isn't necessary, we are finding a few tests that need to be skipped, this is one of them.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:gijs, is there anything I can do to make this bug more actionable?

Comment 2

[:Gijs (away/busy until Mar 10)]

Attachment: Bug 1546482 - clean up added toolbars properly so editcontrols test passes, r?jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aa8d3744f88
clean up added toolbars properly so editcontrols test passes, r=jaws

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3aa8d3744f88