test_findbar.xul is failing when it is not run inside the isolated clipboard job

RESOLVED FIXED in Firefox 68

Status

()

defect
P2
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Here is a try push showing the failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ba44c5d9157a02c97ff3618d8e5c4a101fa1694&searchStr=mochitest-chrome&selectedJob=241874017

there are two other bugs related to this test case, bug 1316862 and bug 1215946.

here is a clip from the win10/opt log:
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | bug 365551: case sensitivity UI is broken after find-again
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | testQuickFindText: failed to open findbar
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | testQuickFindText: find field is not focused
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | testQuickFindText: failed to find 'Text Test' - "Text Test" == "Text Test"
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | Failed to close findbar after testQuickFindText
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | testFindWithHighlight 1: e, e, e.
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | testFindWithHighlight 2: t, t, e, e.
20:55:33 INFO - Buffered messages finished
20:55:33 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_findbar.xul | testFindWithHighlight 3: Highlight All should be checked.
20:55:33 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
20:55:33 INFO - testFindWithHighlight@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:488:7
20:55:33 INFO - asynconDocumentLoaded@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:115:15
20:55:33 INFO - async
startTestWithBrowser@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:96:13
20:55:33 INFO - asynconLoad/<@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:74:17
20:55:33 INFO - onLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:76:9
20:55:33 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:1:1
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | testFindWithHighlight 4: t, e, e.
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | testFindWithHighlight 5: t, t, t.
20:55:33 INFO - Not taking screenshot here: see the one that was previously logged
20:55:33 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_findbar.xul | testFindWithHighlight: Highlight All should be unchecked.
20:55:33 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
20:55:33 INFO - testFindWithHighlight@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:502:7
20:55:33 INFO - async
onDocumentLoaded@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:115:15
20:55:33 INFO - asyncstartTestWithBrowser@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:96:13
20:55:33 INFO - async
onLoad/<@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:74:17
20:55:33 INFO - onLoad@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:76:9
20:55:33 INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/findbar_window.xul:1:1
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | Expected the correct amount of ranges inside the Find selection - 0 == 0
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | testFindWithHighlight: Highlight All should be checked.
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | Expected the correct amount of ranges inside the Find selection - 3 == 3
20:55:33 INFO - TEST-PASS | toolkit/content/tests/chrome/test_findbar.xul | Expected the correct amount of ranges inside the Find selection - 0 == 0

:mikedeboer, is it ok if this test is disabled everywhere? what other information could I give you to help out?

Blocks: 1546459
Flags: needinfo?(mdeboer)

Well, why does this test need to run outside of the dedicated clipboard job?

Flags: needinfo?(mdeboer) → needinfo?(jmaher)

we want to get rid of the clipboard job- running the clipboard job was a workaround to infrastructure issues, but we don't have that limitation anymore.

I was hoping you might know more about this testcase and have a fix for it.

Flags: needinfo?(jmaher)

test_findbar.xul is failing when it is not run inside the isolated clipboard job

Hey Joel, what does that patch do? Does it fix test_findbar.xul because test_bug451540.xul doesn't reset the state properly?

Flags: needinfo?(jmaher)
Priority: -- → P2

yes, I found that by cleaning up properly in test_bug451540.xul it was possible for test_findbar.xul to run properly. I am not sure if my method for cleaning up is the cleanest, but I copied it from the resetForNextTest code:
https://searchfox.org/mozilla-central/source/toolkit/content/tests/chrome/bug451540_window.xul#61

Flags: needinfo?(jmaher)
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05728c3ec053
test_findbar.xul is failing when it is not run inside the isolated clipboard job r=mikedeboer
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → jmaher
You need to log in before you can comment on or make changes to this bug.