1546545 - DLL Interceptor fails to clear trampoline when running under MITIGATION_DYNAMIC_CODE_POLICY

Status: RESOLVED FIXED

(Core :: mozglue, defect, P1)

Description

[David Parks [:handyman]]

Bug 1533808 attempted to fix an issue with the new IOInterposer code where the Chromium sandbox was interfering with our trampoline writing. That fix exposed a failure in media mochitests that turned out to be due to the RDD process sandbox using the MITIGATION_DYNAMIC_CODE_POLICY, which blocks the process from writing to executable memory. That is obviously a problem for the DLL interceptor.

We only wish to be able to write to executable memory because we need to clean up the trampoline on shutdown. Actual trampoline writing should be (and is) done before sandbox lockdown. Since cleaning up at shutdown isn't a critical activity, we can skip it in this case as cleanup is impossible.

These patches also include a small fix for bug 1533808, which was not storing the pointer to the trampoline function with the trampoline's data.

Comment 1

[David Parks [:handyman]]

Attachment: Bug 1546545: Part 1 - Properly store pointer to sandboxed DLL intercepted method r=aklotz

Bug 1533808 introduced code to intercept DLL methods that the Chromium sandbox had already intercepted. That patch did not store the the pointer to the intercepted function in the trampoline data, as is done when intercepting other methods.

Comment 2

[David Parks [:handyman]]

Attachment: Bug 1546545: Part 2 - Create empty TrampolineCollection if the process sandbox forbids dynamic code r=aklotz

TrampolineCollection iterates over an array of Trampolines that it has set 'write' permissions for. If this happens in a process whose sandbox forbids dynamic code then these permissions cannot be set. This patch detects that condition and returns an empty TrampolineCollection in that case. We ASSERT if we fail to set permissions for any other reason.

Depends on D28612

Comment 3

[David Parks [:handyman]]

Debug media tests now pass with IOInterposer changes:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=241258387&revision=dd840770a4c23379601b6c673304a5cbb8285387

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c9f054168c3
Part 1 - Properly store pointer to sandboxed DLL intercepted method r=aklotz

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c0c0c8627c
Part 2 - Create empty TrampolineCollection if the process sandbox forbids dynamic code r=aklotz

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8c9f054168c3
https://hg.mozilla.org/mozilla-central/rev/17c0c0c8627c