1546604 - When selecting folders for offline use, checkboxes can't be set or cleared

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Geoff Lankow (:darktrojan)]

In the Account Settings > Synchronisation and Storage > Advanced dialog, we've got a tree with a column of checkboxes. The checkboxes can't be checked or unchecked.

We've had to fix the message filters dialog the same way recently, so this should be an easy one.

Comment 1

[Jorg K (CEST = GMT+2)]

Aceman might look at the AM.

Comment 2

[:aceman]

Thanks for noticing.

I can see it.
TypeError: XULTreeElement.getCellAt requires at least 2 arguments, but only 1 were passed in msgSelectOfflineFolders.js:72:42

Broken in https://hg.mozilla.org/comm-central/rev/96b12a150fe1. Only this single case did lose the second argument.

There is also another problem in the dialog, when clicking Cancel:
TypeError: this._rollbackMap is undefined msgSelectOfflineFolders.js:100:33

Is 'this' not gSelectOffline when calling the onCancel function from an event listener on "dialogcancel"?

Comment 3

[:aceman]

(In reply to :aceman from comment #2)

There is also another problem in the dialog, when clicking Cancel:
TypeError: this._rollbackMap is undefined msgSelectOfflineFolders.js:100:33

Is 'this' not gSelectOffline when calling the onCancel function from an event listener on "dialogcancel"?

This also happens in the preferences files, e.g. when clicking OK in attachment reminder keywords dialog:
TypeError: this.keywordListBox is undefined in attachmentReminder.js:70:21

Do all the 'this' need to be replaced by the object name? Is this something new?

Comment 4

[:aceman]

Attachment: 1546604.patch

Fix only the checkbox problem, the 'this' issue seems to be more general than just this single dialog so we can discuss it elsewhere.

Comment 5

[Geoff Lankow (:darktrojan)]

I think you'll find this is document in those cases. Probably a screw-up from bug 1541789.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9061225 [details] [diff] [review]
1546604.patch

Damn, I broke that.

Please file a bug for the issue in comment #3 / comment #5.

Comment 7

[:aceman]

Please file a bug for the issue in comment #3 / comment #5.

Bug 1547581.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2344f942f385
fix tree.getCellAt() args in msgSelectOfflineFolders.js (broken in bug 1518823, rev 96b12a150fe1). r=jorgk DONTBUILD

Comment 9

[Jorg K (CEST = GMT+2)]

TB 67 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/173c2e53640c1c4159782a7f8e70754a1eb0eee0