Fix "None" checks when validating test manifests

RESOLVED FIXED in Firefox 68

Status

defect
P1
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

(Blocks 1 bug)

Version 3
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

For streaming tests we cannot always run them through mitmproxy and a recorded playback pageset manifest. As such using the option use_live_sites in the manifest shouldn't require the playback_pageset_manifest and playback_recordings entries:

09:49:37 INFO - raptor-manifest /Users/henrik/code/gecko/testing/raptor/raptor/raptor.ini
09:49:37 INFO - raptor-manifest configuring settings for test raptor-stream-youtube-firefox
09:49:37 INFO - raptor-manifest using live sites so turning playback off!
09:49:37 INFO - raptor-manifest using live sites so appending '-live' to the test name
09:49:37 INFO - raptor-manifest ERROR: setting 'playback_pageset_manifest' is required but not found in /Users/henrik/code/gecko/testing/raptor/raptor/tests/raptor-stream-youtube.ini
09:49:37 INFO - raptor-manifest ERROR: setting 'playback_recordings' is required but not found in /Users/henrik/code/gecko/testing/raptor/raptor/tests/raptor-stream-youtube.ini
09:49:37 INFO - raptor-manifest test raptor-stream-youtube-firefox-live is not valid due to missing settings
09:49:37 INFO - raptor-main abort: no tests found

Problem is that playback in test_details is None, and that is not covered by the condition above:

https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/testing/raptor/raptor/manifest.py#76

Other checks suffer from the same problem. So I'm going to fix all of them.

Summary: "use_live_sites = true" shouldn't require playback recording entries to be set in the manifest → Fix "None" checks when validating test manifests
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4742516f3b5
[raptor] Fix None checks when validating test manifests. r=davehunt
Attachment #9061074 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.