Closed
Bug 1546689
Opened 6 years ago
Closed 6 years ago
Remove substitution of Ci.nsIFooBar with nsIFooBar from SeaMonkey preferences
Categories
(SeaMonkey :: Preferences, enhancement)
SeaMonkey
Preferences
Tracking
(seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.63 wontfix)
RESOLVED
FIXED
seamonkey2.65
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
|
34.47 KB,
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
There are lots of places in SM preferences where there is:
const nsIFooBar = Ci.nsIFooBar
then nsIFooBar is used within the file.
Historically this was probably needed but shouldn't be needed any more.
Attachment #9060419 -
Flags: review?(frgrahl)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9060419 [details] [diff] [review]
Remove substitutions
Looks good. Lets take it to 2.57 for a proper test.
NIT: There are 2 changed lines preserving a trailing blank:
if (rv == nsIFilePicker.returnOK && fp.fileURL.spec &&
Should be removed for checkin.
Attachment #9060419 -
Flags: review?(frgrahl)
Attachment #9060419 -
Flags: review+
Attachment #9060419 -
Flags: approval-comm-esr60+
|
|
||
Updated•6 years ago
|
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
status-seamonkey2.63:
--- → wontfix
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/00a9446e5abc
Remove substitution of Ci.nsIFooBar with nsIFooBar from SeaMonkey preferences. r=frg
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
||
Updated•6 years ago
|
Type: defect → enhancement
Target Milestone: --- → seamonkey2.65
|
|
||
Comment 4•6 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•