1546691 - PeerConnectionObserver can spontaneously go away when network is lost

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

Noticed this while trying to repro bug 1546562 on a local build. My daily-use nightly reproduced the bug fine, but the local build never fired an ICE disconnected event. I went poking around for some preference that I might have left set, and switching from system proxy settings to no proxy got the signal to fire. Very odd.

Comment 1

[Byron Campen [:bwc]]

I've investigated this further, and it seems that sometimes the loss of network can cause the PeerConnectionObserver to spontaneously go away, without the PeerConnection being closed. Specifically, calls like these yield a nullptr:

https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#1191

Does loss of network break some step of this?

https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#1156-1166

Or is the PeerConnectionObserver actually going away here?

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1546691: Avoid the PCObserver going away spontaneously when network is lost.

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8530f6d9ba89807d36423bccfdc6a809dba7fadf

Comment 4

[Byron Campen [:bwc]]

Try looks fine. I might be able to remove some more code.

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0693c671200f3209b01fdb95664662865816d051

Comment 6

[Byron Campen [:bwc]]

Try looks like a mess, but it is already known intermittents.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e46a4bcb07b7
Avoid the PCObserver going away spontaneously when network is lost. r=mjf

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e46a4bcb07b7