Closed Bug 1546724 Opened 5 years ago Closed 4 years ago

Add RTL support for the Reader View panel

Categories

(Toolkit :: Reader Mode, defect, P3)

Product:
Toolkit
Component:
Reader Mode
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: itiel_yn8, Unassigned)

Details

(Keywords: rtl, Whiteboard: [about-reader-ui])

Things to do to make the Reader View RTL supported:

  1. Move the panel to the right side of the content area
  2. Make the popups connect to their buttons from the right side of the popups
  3. Mirror the following icons:
    a. Toggle reader view icon on the URL bar
    b. Close Reader View icon
    c. Decrease Line Height icon
    d. Increase Line Height icon
  4. (Not critical, but appreciated) Horizonally reverse the order of the items in the "Aa" popup (so e.g. the Decrease Line Height icon and "Light" on the right, and the Increase Font Size icon and "Sepia" on the left)

The tricky thing here is mixing this with the directionality of the content in the right way, see https://searchfox.org/mozilla-central/rev/d143f8ce30d1bcfee7a1227c27bf876a85f8cede/toolkit/components/reader/AboutReader.jsm#817 . We'd want to set the locale direction on the body or whatever and then use that to position the toolbar differently and do everything else listed in comment #0.

Priority: -- → P3
Whiteboard: [about-reader-ui]

Fixed by the great work made in bug 1637652.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.