Closed Bug 1546734 Opened 4 months ago Closed 4 months ago

[Card] Adjust vertical spacing and text color

Categories

(Firefox :: New Tab Page, enhancement, P1)

67 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Status
firefox68 --- verified

People

(Reporter: wolasi, Assigned: gsuntop)

References

Details

(Keywords: github-merged)

Attachments

(2 files, 4 obsolete files)

Make the following changes for all cards

Requirements

  • For 4-column card size, title font-size should be 15px
  • Change excerpt text color to gray-90 (gray-10 for dark theme)
  • Remove vertical spacing between title and excerpt
  • Change text color of sponsored by label to gray-50 (gray-40 for dark theme)
  • See spec for vertical spacing adjustments

Spec
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/New-Tab-Spec-for-Fx-v68?node-id=442%3A1

Colors
https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-New-Tab-Components?node-id=41%3A256

Assignee: nobody → gsuntop
Attachment #9061109 - Flags: data-review?(wkonu)
Attachment #9061109 - Flags: data-review?(wkonu) → ui-review?(wkonu)

Hard to tell from the screenshot but…

  • Was an adjustment made to the vertical spacing between the image and the title? Should be 12px per the spec
  • Similarly the min vertical spacing between the excerpt and the "Sponsored by…" label

Also can we get a screenshot of layout with 3-colum card layout for review?

Flags: needinfo?(gsuntop)
Type: defect → enhancement
Iteration: --- → 68.4 - Apr 29 - May 12
Priority: -- → P1

(In reply to Wolasi from comment #3)

Hard to tell from the screenshot but…

  • Was an adjustment made to the vertical spacing between the image and the title? Should be 12px per the spec

Will make that tweak.

  • Similarly the min vertical spacing between the excerpt and the "Sponsored by…" label

There is a 12px min margin there. Did you want something else?

Also can we get a screenshot of layout with 3-colum card layout for review?

Will add this!

Flags: needinfo?(gsuntop)
Attached image 1546734-dev-test-all.jpg (obsolete) —
Attachment #9061109 - Attachment is obsolete: true
Attachment #9061109 - Flags: ui-review?(wkonu)
Attachment #9062285 - Flags: ui-review?(wkonu)
  • Source color for the largest story in the hero should be gray
  • Remove spacing between title and excerpt for the largest hero story
  • Vertical spacing between image and text below should 12px
  • Vertical spacing between the excerpt and the Sponsor label should be 10px
Flags: needinfo?(gsuntop)
Attached image 1546734-dev-test-all-2.jpg (obsolete) —
Attachment #9062285 - Attachment is obsolete: true
Attachment #9062285 - Flags: ui-review?(wkonu)
Flags: needinfo?(gsuntop)
Attachment #9062595 - Flags: ui-review?(wkonu)

Looking good! We might as well change the source and sponsor text for list items too.

Attached image 1546734-dev-test-all-3.jpg (obsolete) —

Tweaked list colors.

Attachment #9062595 - Attachment is obsolete: true
Attachment #9062595 - Flags: ui-review?(wkonu)
Attachment #9063014 - Flags: ui-review?(wkonu)

Text excerpt color for hero main story should be gray-90 (gray-10 for dark theme)

Attachment #9063014 - Attachment is obsolete: true
Attachment #9063014 - Flags: ui-review?(wkonu)
Attachment #9063019 - Flags: ui-review?(wkonu)

LGTM

Blocks: 1549863
Status: NEW → RESOLVED
Closed: 4 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190509214305) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the cards are respecting the changes from comment 0.

Status: RESOLVED → VERIFIED
Attachment #9063019 - Flags: ui-review?(wkonu)
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.