1546738 - Get rid of the hidden window usage to get a WebSocket object

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[:Felipe Gomes (needinfo for replies!)]

There are two places in the developer tools codebase [1] [2] where the hidden window is used to get access to a WebSocket object. We should figure out a way to make that getter lazy or switch to some alternative to using the hidden window.

[1] https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/remote/server/WebSocket.jsm#18
[2] https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/devtools/shared/builtin-modules.js#375

Comment 1

[Patrick Brosset <:pbro>]

CC'ing Alex to put this on his radar as this is related to DevTools' protocol transport layer.
Marking as a P3 for now since the parent bug does not seem to have any priority associated to it. If the perf benefits of doing this change are big enough for Firefox, we should probably bump this.

Comment 2

[Gregory Pappas [:gregp]]

Attachment: Bug 1546738 - Get rid of the hidden window usage to get a WebSocket object

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e4848e63a94
Get rid of the hidden window usage to get a WebSocket object r=ochameau,devtools-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0e4848e63a94