Closed Bug 1546747 Opened 5 years ago Closed 5 years ago

TypeError: session is null in Cookie preferences dialog.

Categories

(SeaMonkey :: Passwords & Permissions, defect)

Product:
SeaMonkey
Component:
Passwords & Permissions
Version:
SeaMonkey 2.43 Branch
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(seamonkey2.49esr fixed, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.65
Tracking Flags:
Tracking Status
seamonkey2.49esr --- fixed
seamonkey2.63 --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: frg)

References

(Regression)

Details

Attachments

(1 file, 1 obsolete file)

1546747-cookiesession-68a1.patch
1.48 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-esr52+
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review

+++ This bug was initially created as a clone of Bug #1235199 +++

Timestamp: 4/24/2019, 8:05:56 PM
Error: TypeError: session is null
Source File: chrome://communicator/content/pref/pref-cookies.js
Line: 27

Fallout from Bug 1235199. Element alwaysAcceptSession no longer exists.

Attached patch 1546747-cookiesession-68a1.patch (obsolete) — — Splinter Review
Attachment #9060497 - Flags: approval-comm-esr60?
Attachment #9060497 - Flags: approval-comm-esr52?
Attachment #9060497 - Flags: review?(iann_bugzilla)

wrong patch

Attachment #9060497 - Attachment is obsolete: true
Attachment #9060497 - Flags: review?(iann_bugzilla)
Attachment #9060497 - Flags: approval-comm-esr60?
Attachment #9060497 - Flags: approval-comm-esr52?
Attachment #9060499 - Flags: review?(iann_bugzilla)
Attachment #9060499 - Flags: approval-comm-esr60?
Attachment #9060499 - Flags: approval-comm-esr52?
Comment on attachment 9060499 [details] [diff] [review]
1546747-cookiesession-68a1.patch

kAskBeforeAccepting is still declared as a const but no longer used. Should I set it as a comment or take it completly out
Comment on attachment 9060499 [details] [diff] [review]
1546747-cookiesession-68a1.patch

Yes, remove kAskBeforeAccepting but change the comment above it to say what 1 used to stand for. e.g. historically 1 meant ask before accepting but is no longer used.
r/a=me with that done
Attachment #9060499 - Flags: review?(iann_bugzilla)
Attachment #9060499 - Flags: review+
Attachment #9060499 - Flags: approval-comm-esr60?
Attachment #9060499 - Flags: approval-comm-esr60+
Attachment #9060499 - Flags: approval-comm-esr52?
Attachment #9060499 - Flags: approval-comm-esr52+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/9606c2de0818
Remove references to non existing element alwaysAcceptSession in cookie preferences. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: