1546840 - It should be possible to do a gloda query for unread messages

Status: RESOLVED FIXED

(MailNews Core :: Database, enhancement)

Description

[Geoff Lankow (:darktrojan)]

There is a "read" attribute, but it's not possible to query it. As I understand it, setting canQuery on the attribute to a truthy-but-not-true value will do the trick:

From gloda.js:

the new canQuery property has to be set to true to generate entries
in the messageAttributes table. Any other truthy value (like a non
empty string), will still make the message query-able but without
using the database.

I just wonder if there's a reason it hasn't been done before.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1546840-gloda-canquery-1.diff

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9063150 [details] [diff] [review]
1546840-gloda-canquery-1.diff

Review of attachment 9063150 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/db/gloda/modules/explattr.js
@@ +88,5 @@
>                          provider: this,
>                          extensionName: Gloda.BUILT_IN,
>                          attributeType: Gloda.kAttrExplicit,
>                          attributeName: "read",
> +                        // See the note in grokNounItem about canQuery.

Can you copy over the comment too?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/305d1bc1bda9
Allow GloDa queries for read or unread messages; r=mkmelin