Improve error handling of IPDL analyzer
Categories
(Webtools :: Searchfox, defect)
Tracking
(Not tracked)
People
(Reporter: mccr8, Assigned: asuth)
References
Details
Attachments
(1 file)
Right now, the IPDL parser just bails out if any file fails to parse. It would be nice if it would instead warn! for files that didn't work, and then just produce results for the rest of it. I'm not entirely sure the best way to go about it. I think it will require some changes from the IPDL parser if I do it in the most straightforward way. I probably also want to make sure the existing failure is fixed before I start warning, or we'll get mail every day.
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
This is a very simple patch, but it does improve error handling! I think in general we've been talking about just moving to having the in-tree parser generate the analysis data as a byproduct, so I'm not sure it makes sense to keep this bug around for other purposes.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Landed https://github.com/mozsearch/ipdl_parser/pull/6 on mozsearch in https://github.com/mozsearch/mozsearch/pull/343. Prematurely marking this fixed.
This should manifest tomorrow as IPDL files being indexed at all instead of not at all, but a bunch of things still won't get indexed. (Bug 1555857 will improve this.)
Description
•