Closed Bug 1546931 Opened 5 months ago Closed 16 days ago

installs.ini and profiles.ini should not be both stat'ed and read using main thread I/O during early startup

Categories

(Toolkit :: Startup and Profile System, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox67 - wontfix
firefox67.0.1 - wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: florian, Assigned: mandycheang135)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxperf:p2] [fxperfsize:S])

Attachments

(1 file)

I thought we had fixed this in bug 1527704, but I saw a stat call for installs.ini reappear recently when updating my whitelist for the test in bug 1540135.

Here's a profile on the reference hardware on today's nightly: https://perfht.ml/2L4Rn87

This will have been caused by bug 1529879.

Regressed by: 1529879

Thinking about this I think we can skip doing this stat check entirely...

Priority: -- → P2

Given comment #2, I assume this is straightforward.

Whiteboard: [fxperf] → [fxperf:p2] [fxperfsize:S]

Too late for a fix in 68 at this point as we are a week away from 68 release.

(In reply to Dave Townsend [:mossop] (he/him) from comment #2)

Thinking about this I think we can skip doing this stat check entirely...

I just saw this installs.ini stat be visible in a startup profile today: https://perfht.ml/2ZmGpxB

The only place in the code that seems to use this value is https://searchfox.org/mozilla-central/rev/38c88cbf4be87dfa0636d15a5d3599a8ea0d1a72/toolkit/profile/nsToolkitProfileService.cpp#656 I doubt this is needed during startup. Do we even need it at all?

Flags: needinfo?(dtownsend)

No, as I alluded to in comment 2 I don't think we actually need the installs.ini stat at all (except for the rebuild case). installs.ini cannot change without profiles.ini changing first so the stat is pointless.

Flags: needinfo?(dtownsend)
Flags: needinfo?(mconley)
Assignee: nobody → mcheang
Flags: needinfo?(mconley)
Attachment #9087854 - Attachment description: Bug 1546931 - Remove installs.ini and profiles.ini stat during early start-up on the main thread. r=mconley,mossop → Bug 1546931 - Remove installs.ini stat during early start-up on the main thread. r=mconley,mossop

This patch is not ready to land yet. I'm currently fixing a Xpcshell test failure for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ef2b7e34360834eca12d2194c6649e11a72cf80

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/986d8d0e5af2
Remove installs.ini stat during early start-up on the main thread. r=mossop
Status: NEW → RESOLVED
Closed: 16 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Best to leave this to ride with nightly or do you think it is safe to uplift to early beta 70?

Flags: needinfo?(mandycheang135)

I don't think it's necessary to rush this - it can probably just stay on Nightly.

Flags: needinfo?(mandycheang135)
You need to log in before you can comment on or make changes to this bug.