Closed Bug 1546955 Opened 7 months ago Closed 7 months ago

Force MakeDisplayItem() callers to supply a frame

Categories

(Core :: Web Painting, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: miko, Assigned: miko)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Since display items rely on having at least one frame, force callers to pass it to MakeDisplayItem() function. This allows us to do things such as look up previous display items before building a new one.
This patch also changes the cloning implementation by forcing custom copy-constructors to be called through MakeClone().

Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f9c160fec2c4
Part 1: Invoke display item copy-constructors through MakeClone() r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/b16160b39a3f
Part 2: Make all display item constructors take nsDisplayListBuilder and frame as the first two parameters r=mattwoodrow
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.