1546955 - Force MakeDisplayItem() callers to supply a frame

Status: RESOLVED FIXED

(Core :: Web Painting, task, P2)

Description

[Miko Mynttinen]

Since display items rely on having at least one frame, force callers to pass it to MakeDisplayItem() function. This allows us to do things such as look up previous display items before building a new one.
This patch also changes the cloning implementation by forcing custom copy-constructors to be called through MakeClone().

Comment 1

[Miko Mynttinen]

Attachment: Bug 1546955 - Part 1: Invoke display item copy-constructors through MakeClone() r=kamidphish

Comment 2

[Miko Mynttinen]

Attachment: Bug 1546955 - Part 2: Make all display item constructors take nsDisplayListBuilder and frame as the first two parameters r=kamidphish

Depends on D28844

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9c160fec2c4
Part 1: Invoke display item copy-constructors through MakeClone() r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/b16160b39a3f
Part 2: Make all display item constructors take nsDisplayListBuilder and frame as the first two parameters r=mattwoodrow

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f9c160fec2c4
https://hg.mozilla.org/mozilla-central/rev/b16160b39a3f