154698 - After importing bad bookmarks file, all bookmarks are lost

Status: VERIFIED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Simon Fraser [no longer active]]

I did an 'Import bookmarks' and imported a bookmarks file generated with
Mozilla. The showed up in the sidebara that time, and all worked.

Then I quit and restarted, and all my bookmarks were gone. A couple of empty
items, and an empty folder showed up in the sidebar. The bookmarks.xml file now
contains:

<parsererror xmlns="http://www.mozilla.org/newlayout/xml/parsererror.xml">XML
Parsing Error: not well-formed
Location:
file:///Volumes/Data/Users/smfr/Library/Chimera/Profiles/default/fcxev8ti.slt/bookmarks.xml
Line Number 3, Column 20707:<sourcetext>"
href="http://www.usembassy.org.uk/"/&gt;&lt;bookmark name="Visa Services
-&amp;gt; Non-Imigrant Visas -&amp;gt; Work Visas -&amp;gt; Application
Procedures"
href="http://www.usembassy.org.uk/cons_web/visa/niv/happ.htm"/&gt;&lt;bookmark
name="g a r d e n  c o u r t  h o t e l  [ www.gardencourthotel.co.uk]"
href="http://www.gardencourthotel.co.uk/index.html"/&gt;&lt;bookmark
name="London Bed and Breakfast Agency - Places to stay in London, London holiday
homes, Budget accommodation in London, London accommodation agency"
href="http://www.londonbb.com/"/&gt;&lt;bookmark name="Noise-Canceling
Headphones"
href="http://www.producersconference.com/technology/personal/headphones/headphones.html"/&gt;&lt;bookmark
name="totaljourney"
href="http://www.totaljourney.com/tj/totaljourney?handler=com.equant.tj.handler.request.rail.TJRailStartingPointRequestHandler&amp;amp;start=home"/&gt;&lt;bookmark
name="London Pass"
href="http://www.londonpass.com/art_page.html"/&gt;&lt;bookmark name="Flame 1"
href="http://www.winternet.com/~mikelr/flame1.html"/&gt;&lt;bookmark name="On
the Road in North-West Scotland"
href="http://www.remote.org/frederik/roadhog/scotland/"/&gt;&lt;bookmark
name="Writing A Device Driver In C++ (What? In C++?)"
href="http://www.mactech.com/articles/develop/issue_04/device_driver.html"/&gt;&lt;bookmark
name="Powamate Ltd. - Solar Pump Kit"
href="http://www.powamate.com/pump.html"/&gt;&lt;bookmark name="Nursery Pro
Solar Products by Pond Supplies R Us"
href="http://www.pondsuppliesrus.com/npsolar2.htm"/&gt;&lt;bookmark name="About
This Book"
href="http://developer.apple.com/techpubs/hardware/DeviceManagers/pci_srvcs/pci_cards_drivers/PCI_BOOK.html"/&gt;&lt;bookmark
name="MT-NW Manual: Frequently Asked Questions"
href="http://www.smfr.org/mtnw/docs/FAQ.html#reread_an_old_article"/&gt;&lt;bookmark
name="TN 2028: Threading Architectures"
href="http://developer.apple.com/technotes/tn/tn2028.html"/&gt;&lt;bookmark
name="MacOS X screensavers programming common errors"
href="http://spazioweb.inwind.it/tpecorella/uselesssoft/mistakes.htm"/&gt;&lt;bookmark
name="Lightsoft: Beginners Guide to PowerPC Assembly Language"
href="http://www.lightsoft.co.uk/Fantasm/Beginners/begin1.html"/&gt;&lt;bookmark
name="March 95 - Balance of Power: Introducing PowerPC Assembly Language"
href="http://ksi.ii.uj.edu.pl/armo/amideveloper/dev/ppc_cursus.html"/&gt;&lt;bookmark
name="Sunnyvale Municipal Code"
href="http://ordlink.com/codes/sunnyval/index.htm"/&gt;&lt;bookmark
name="Directory of /products/client/6.x/macos/8.x/ppc"
href="ftp://sweetlou/products/client/6.x/macos/8.x/ppc/"/&gt;&lt;bookmark
name="No More Popup Ads"
href="http://technoerotica.net/mylog/optouts.html"/&gt;&lt;folder name="Imported
IE Favorites"&gt;&lt;folder name="Toolbar Favorites"&gt;&lt;folder
name="Microsoft Web Sites"&gt;&lt;bookmark name="Products for Mac"
href="http://www.microsoft.com/mac/"/&gt;&lt;bookmark name="Microsoft Internet
Explorer" href="http://www.microsoft.com/mac/ie/"/&gt;&lt;bookmark
name="Microsoft Outlook Express"
href="http://www.microsoft.com/mac/oe/"/&gt;&lt;bookmark name="Microsoft Office"
href="http://www.microsoft.com/macoffice/default.asp"/&gt;&lt;bookmark
name="Microsoft" href="http://www.microsoft.com/"/&gt;&lt;/folder&gt;&lt;folder
name="MSN Web Sites"&gt;&lt;bookmark name="Microsoft® bCentral"
href="http://www.bcentral.com/"/&gt;&lt;bookmark name="Microsoft® Passport"
href="http://www.passport.com/"/&gt;&lt;bookmark name="Microsoft® WindowsMedia"
href="http://windowsmedia.microsoft.com/"/&gt;&lt;bookmark name="MSN Auctions"
href="http://auctions.msn.com/"/&gt;&lt;bookmark name="MSN CarPoint"
href="http://carpoint.msn.com/"/&gt;&lt;bookmark name="MSN Encarta Online"
href="http://encarta.msn.com/"/&gt;&lt;bookmark name="MSN eShop"
href="http://eshop.msn.com/"/&gt;&lt;bookmark name="MSN Expedia"
href="http://expedia.msn.com/"/&gt;&lt;bookmark name="MSN HomeAdvisor"
href="http://homeadvisor.msn.com/"/&gt;&lt;bookmark name="MSN Hotmail"
href="http://www.hotmail.com/"/&gt;&lt;bookmark name="MSN Messenger Service"
href="http://messenger.msn.com/"/&gt;&lt;bookmark name="MSN MoneyCentral"
href="http://moneycentral.msn.com/"/&gt;&lt;bookmark name="MSN.COM"
href="http://www.msn.com/"/&gt;&lt;bookmark name="MSNBC"
href="http://www.msnbc.com/"/&gt;&lt;/folder&gt;&lt;bookmark name="Apple"
href="http://www.apple.com/"/&gt;&lt;/folder&gt;&lt;/fold
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------^</sourcetext><a0:folder
xmlns:a0="http://chimera.mozdev.org/bookmarks/" name="Toolbar Bookmarks"
type="toolbar" open="true"/></parsererror>
This is a serious dataloss bug.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Sample bad HTML bookmarks file to import.

Comment 2

[Simon Fraser [no longer active]]

Working on a fix.

Comment 3

[Simon Fraser [no longer active]]

I checked in a fix. What I do now is to import the bookmarks into the bookmarks
XML document, and then validate that document (by serializing and reparsing it).
If that fails, I show the user a dialog, and remove the imported nodes from the
bookmarks, returning them to their former state.

Comment 4

[Simon Fraser [no longer active]]

*** Bug 149172 has been marked as a duplicate of this bug. ***

Comment 5

[sairuh (rarely reading bugmail)]

vrfy'd fixed, 2002.08.26.05. tested using the sample attachment: the file was
imported as a folder and the bad bookmark in it was retained (the bad chars
stripped out).