1546981 - webrtc/RTCPeerConnection-setLocalDescription-answer.html has a duplicate test-case

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P2)

Description

[Byron Campen [:bwc]]

Merging upstream has resulted in one of the test cases ("Setting previously generated answer after a call to createOffer should work") being duplicated. The dupe needs to be removed.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1546981: Remove duplicate test-case, and remove an error suppression it caused. r?jib

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59c2630d51962dc67d8fd2bd5571588624711172

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f17694b16858208e4d8ed3c46585900ce7ba1a1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/324eb86aaf5b
Remove duplicate test-case, and remove an error suppression it caused. r=jib

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/324eb86aaf5b

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17063 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 9

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Note that this got reverted upstream. Please see comments there.

Comment 10

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

The test is still there so that's the important part. Some form of merge issue may have been the original cause, who knows.

Comment 11

[Byron Campen [:bwc]]

Yeah, there was a merge problem on both ends, but I think things have been fixed on both ends.