1546983 - Tall videos result in glitchy looking Picture-in-Picture player buttons

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

+++ This bug was initially created as a clone of Bug #1545763 +++

STR:

0. Ensure media.videocontrols.picture-in-picture.enabled and media.videocontrols.picture-in-picture.video-toggle.enabled are set to true
1. Visit https://facebook.com/ and log in with a valid account
2. Scroll down until you find a video in portrait mode on your home page
3. The video starts and the toggle button is displayed
4. Click on the toggle button to open the Picture in Picture window

ER:

The Picture-in-Picture player window controls should match the spec.

AR:

The buttons in the player window look "duplicated" and stretched. See screenshot.

Note:
If you can't find a video you can use this link:
https://www.facebook.com/watch/?v=326853498025559

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screenshot

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Do you have time to look at this, JSON_Voorhees?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1546983 - Make Picture-in-Picture player control buttons always a square proportional to the max window dimension. r?dthayer

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1546983 - Make the Picture-in-Picture player window control buttons less sensitive to being in a thin window. r?dthayer

Depends on D30279

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7157a9384870
Make Picture-in-Picture player control buttons always a square proportional to the max window dimension. r=dthayer
https://hg.mozilla.org/integration/autoland/rev/8a953fd10269
Make the Picture-in-Picture player window control buttons less sensitive to being in a thin window. r=dthayer

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb3846630789
followup: use background-color instead of background so that browser_parsable_css.js doesn't get mad. rs=mconley

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7157a9384870
https://hg.mozilla.org/mozilla-central/rev/8a953fd10269
https://hg.mozilla.org/mozilla-central/rev/eb3846630789

Comment 10

[Cristian Craciun]

Build ID 20190626093633
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on the latest Nightly build on Windows 10.