Closed Bug 1546990 Opened 8 months ago Closed 8 months ago

Refactor setTimeout() in several files to avoid triggering eval() assertion.

Categories

(Core :: DOM: Security, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jallmann, Assigned: jallmann)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(1 file)

Several occurences of setTimeout() can be refactored to be passed anonymous functions instead of string literals. This way, they don't trigger the eval()-assertion from Bug 1473549 and the respective files can be removed from the whitelist for this assertion.
The affected files are:

https://searchfox.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/TestRunner.js

https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_execute_async_script.py

https://searchfox.org/mozilla-central/source/layout/base/tests/chrome/file_bug1018265.xul

https://searchfox.org/mozilla-central/source/toolkit/mozapps/downloads/HelperAppDlg.jsm

Refactor several occurences of setTimeout() to avoid triggering the eval() assertion.

Keywords: checkin-needed

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9847a8b2005e
Remove several files from eval()-assertion whitelist, r=ckerschb

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.