Closed Bug 1547017 Opened 5 years ago Closed 5 years ago

[about:addons] Hide the more-options button when the menu is empty

Categories

(Toolkit :: Add-ons Manager, task, P3)

Product:
Toolkit
Component:
Add-ons Manager
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- fixed
firefox67 --- disabled
firefox68 --- wontfix
firefox69 --- verified
firefox70 --- verified

People

(Reporter: mstriemer, Assigned: mstriemer)

References

Details

Attachments

(1 file)

Bug 1547017 - Hide the more options button when there are no items r?rpl
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
RyanVM
: approval-mozilla-esr68+
Details | Review

When you have the default theme enabled and go to its details page there are no available actions in the more options menu. If the more options menu is empty, then the button to open it should be hidden.

Priority: P1 → P3
Type: defect → task
Assignee: nobody → mstriemer
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/817e56e31d6a
Hide the more options button when there are no items r=mixedpuppy

https://hg.mozilla.org/mozilla-central/rev/817e56e31d6a

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Please nominate this for Beta and ESR68 approval when you get a chance.

status-firefox68: affected → wontfix
status-firefox-esr68: --- → affected
Flags: in-testsuite+

Comment on attachment 9079848 [details]
Bug 1547017 - Hide the more options button when there are no items r?rpl

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: It's a small change that fixes an annoyance on the default theme's details page when it is enabled.
  • User impact if declined: There is a button to open the menu to manage the default theme on its detail page, even when there are no management options.
  • Fix Landed on Version: 70
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Hides unusable UI, has automated tests.
  • String or UUID changes made by this patch: No

Beta/Release Uplift Approval Request

  • User impact if declined: There is a button to open the menu to manage the default theme on its detail page, even when there are no management options.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Hides unusable UI, has automated tests.
  • String changes made/needed: No
Attachment #9079848 - Flags: approval-mozilla-esr68?
Attachment #9079848 - Flags: approval-mozilla-beta?

Comment on attachment 9079848 [details]
Bug 1547017 - Hide the more options button when there are no items r?rpl

Fixes a bug causes unnecessary UI to show and adds a new test for it. Approved for 69.0b9.

Attachment #9079848 - Flags: approval-mozilla-esr68?
Attachment #9079848 - Flags: approval-mozilla-esr68+
Attachment #9079848 - Flags: approval-mozilla-beta?
Attachment #9079848 - Flags: approval-mozilla-beta+

Verified as fixed in FF70.0a1(20190811215021) and 69.0b12(20190807220259) on Win7x64 and MacOS 10.14.1
Button no longer displayed if not options are available.

Status: RESOLVED → VERIFIED
status-firefox69: fixed → verified
status-firefox70: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: