Support snapshotting with BGRA instead of RGBA
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(2 files)
For reftest snapshotting, we do a glReadPixels which apparently fails on GLES if we're trying to read a BGRA8. On my Pixel 2 at least the glReadPixels operation is failing and the GLError is set to INVALID_OPERATION.
Jamie says we should change the snapshotting code to use RGBA8 instead for GLES.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
The Rgba8 enum value is redundant with the Standard(ImageFormat::RGBA8) value,
this patch collapses the former into the latter. When then makes the entire
ReadPixelsFormat redundant, so we can get rid of it completely.
|
|
Assignee | |
Comment 2•5 years ago
|
||
BGRA may not be supported on GLES implementations, such as on the
Pixel 2 device. Since WR on Android uses GLES, we should use RGBA
when getting snapshots so that it actually works instead of failing
silently.
Depends on D29059
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8489b0f35bd6 Remove ReadPixelsFormat. r=kvark https://hg.mozilla.org/integration/autoland/rev/f1a87f870052 Get snapshots in RGBA8 instead of BGRA8 on Android. r=jnicol
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8489b0f35bd6
https://hg.mozilla.org/mozilla-central/rev/f1a87f870052
Description
•