1547100 - Perma [tier2] test_serviceworker_interfaces.html | test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: dvarga [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=242663005&repo=autoland

https://queue.taskcluster.net/v1/task/KVmS6s1lSRekX23yBxtv8w/runs/0/artifacts/public/logs/live_backing.log

task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - 2385 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | RadioNodeList is exposed as an own property on the window but has no property descriptor in the global scope
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - Buffered messages finished
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - 2386 INFO TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:18
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - runTest@https://example.com/tests/dom/tests/mochitest/general/test_interfaces.js:1315:5
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - @https://example.com/tests/dom/tests/mochitest/general/test_interfaces.js:1338:1
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - 2387 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | StorageManager is exposed as an own property on the window but tests false for "in" in the global scope
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - 2388 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | StorageManager is exposed as an own property on the window but has no property descriptor in the global scope

Comment 1

[Intermittent Failures Robot]

114 failures in 577 pushes (0.198 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 95
• mozilla-central: 11
• mozilla-inbound: 8

Platform breakdown:

• android-em-7-0-x86_64: 114

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1547100&startday=2019-04-25&endday=2019-04-25&tree=all

Comment 2

[Andreea Pavel [:apavel]]

There are 182 total failures since the bug was filed on android-em-7-0-x86_64 opt.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242837909&repo=autoland&lineNumber=4236

[task 2019-04-26T10:49:28.447Z] 10:49:28 INFO - 1707 INFO TEST-START | dom/serviceworkers/test/test_serviceworker_interfaces.html
[task 2019-04-26T10:49:28.451Z] 10:49:28 INFO - <snipped 29 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>
[task 2019-04-26T10:49:28.451Z] 10:49:28 INFO - Buffered messages logged at 10:49:20
[task 2019-04-26T10:49:28.451Z] 10:49:28 INFO - 1708 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface Error to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

[task 2019-04-26T10:49:28.486Z] 10:49:28 INFO - 1806 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface ServiceWorker to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1807 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface ServiceWorkerRegistration to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - Buffered messages finished
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1808 INFO TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/test_serviceworker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - setupSW/window.onmessage@dom/serviceworkers/test/test_serviceworker_interfaces.html:31:9
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1809 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface SubtleCrypto to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1810 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface TextDecoder to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1811 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface TextEncoder to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1812 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface URL to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1813 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface URLSearchParams to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1814 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WebSocket to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1815 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WindowClient to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1816 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WorkerLocation to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1817 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WorkerNavigator to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1818 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: Atomics should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1819 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: SharedArrayBuffer should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1820 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushEvent should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1821 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushManager should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1822 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushMessageData should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1823 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushSubscription should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1824 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushSubscriptionOptions should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1825 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | 0 === 0: The following interface(s) are not enumerated:
[task 2019-04-26T10:49:28.490Z] 10:49:28 INFO - 1826 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | The service worker should be unregistered successfully
[task 2019-04-26T10:49:28.490Z] 10:49:28 INFO - 1827 INFO TEST-OK | dom/serviceworkers/test/test_serviceworker_interfaces.html | took 269ms

Comment 3

[Emily Toop (:fluffyemily)]

I was unaware I had to update the mochitests. Updating now.

Comment 4

[Intermittent Failures Robot]

252 failures in 763 pushes (0.33 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 197
• mozilla-inbound: 38
• mozilla-central: 13
• try: 4

Platform breakdown:

• android-em-7-0-x86_64: 251
• android-em-4-3-armv7-api16: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1547100&startday=2019-04-26&endday=2019-04-26&tree=all

Comment 5

[Intermittent Failures Robot]

91 failures in 224 pushes (0.406 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 58
• mozilla-inbound: 20
• mozilla-central: 9
• try: 4

Platform breakdown:

• android-em-7-0-x86_64: 91

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1547100&startday=2019-04-27&endday=2019-04-27&tree=all

Comment 7

[Andreea Pavel [:apavel]]

Hi Emily, are there any updates here?

Comment 8

[Intermittent Failures Robot]

494 failures in 3031 pushes (0.163 failures/push) were associated with this bug in the last 7 days.

This is the #3 most frequent failure this week.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 363
• mozilla-inbound: 79
• mozilla-central: 43
• try: 9

Platform breakdown:

• android-em-7-0-x86_64: 493
• android-em-4-3-armv7-api16: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1547100&startday=2019-04-22&endday=2019-04-28&tree=all

Comment 9

[Emily Toop (:fluffyemily)]

I'm trying to update the test such that it only runs for GeckoView and not for Fennec, but so far haven't found the right set of flags to switch off only Fennec.

Comment 10

[Emily Toop (:fluffyemily)]

Attachment: Enable GV StorageManager testing in Mochitests.

We want to start exposing the storage manager through GeckoView app, but continue not exposing it in Fennec. To enable this a new entry type for Fennec only (different from generic Android) is added to allow us to continue to exclude Fennec from the tests while enabling the tests for other Android builds.

Comment 11

[Intermittent Failures Robot]

233 failures in 741 pushes (0.314 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 182
• mozilla-inbound: 24
• mozilla-central: 19
• try: 8

Platform breakdown:

• android-em-7-0-x86_64: 233

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1547100&startday=2019-04-29&endday=2019-04-29&tree=all

Comment 12

[Andreea Pavel [:apavel]]

Emily, your patch got a review+, can we land it?

Comment 13

[Intermittent Failures Robot]

300 failures in 772 pushes (0.389 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 228
• mozilla-inbound: 46
• mozilla-central: 19
• try: 7

Platform breakdown:

• android-em-7-0-x86_64: 300

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1547100&startday=2019-04-30&endday=2019-04-30&tree=all

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a3c75d8e68a
Enable GV StorageManager testing in Mochitests. r=asuth

Comment 15

[Emily Toop (:fluffyemily)]

Queued for landing.

Comment 16

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6a3c75d8e68a

Comment 17

[Intermittent Failures Robot]

51 failures in 689 pushes (0.074 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 36
• mozilla-central: 2
• mozilla-inbound: 7
• try: 6

Platform breakdown:

• android-em-7-0-x86_64: 51

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1547100&startday=2019-05-01&endday=2019-05-01&tree=all

Comment 18

[Intermittent Failures Robot]

584 failures in 4131 pushes (0.141 failures/push) were associated with this bug in the last 7 days.

This is the #1 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 446
• mozilla-inbound: 77
• mozilla-central: 40
• try: 21

Platform breakdown:

• android-em-7-0-x86_64: 584

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1547100&startday=2019-04-29&endday=2019-05-05&tree=all

Comment 20

[Intermittent Failures Robot]

1 failures in 3444 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• android-em-7-0-x86_64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1547100&startday=2022-01-17&endday=2022-01-23&tree=all