Closed Bug 1547100 Opened 5 years ago Closed 5 years ago

Perma [tier2] test_serviceworker_interfaces.html | test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window?

Categories

(Core :: DOM: Core & HTML, defect, P1)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: fluffyemily)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file)

Enable GV StorageManager testing in Mochitests.
47 bytes, text/x-phabricator-request
Details | Review

#[markdown(off)]
Filed by: dvarga [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=242663005&repo=autoland

https://queue.taskcluster.net/v1/task/KVmS6s1lSRekX23yBxtv8w/runs/0/artifacts/public/logs/live_backing.log

task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - 2385 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | RadioNodeList is exposed as an own property on the window but has no property descriptor in the global scope
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - Buffered messages finished
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - 2386 INFO TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:18
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - runTest@https://example.com/tests/dom/tests/mochitest/general/test_interfaces.js:1315:5
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - @https://example.com/tests/dom/tests/mochitest/general/test_interfaces.js:1338:1
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - 2387 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | StorageManager is exposed as an own property on the window but tests false for "in" in the global scope
[task 2019-04-25T17:55:25.555Z] 17:55:25 INFO - 2388 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces_secureContext.html | StorageManager is exposed as an own property on the window but has no property descriptor in the global scope

Regressed by: 1527074
Summary: Intermittent dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window? Do not make a change to this → Perma [tier2] Intermittent dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window?
Summary: Perma [tier2] Intermittent dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window? → Perma [tier2] Intermittent test_serviceworker_interfaces.html | test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window?

There are 182 total failures since the bug was filed on android-em-7-0-x86_64 opt.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242837909&repo=autoland&lineNumber=4236

[task 2019-04-26T10:49:28.447Z] 10:49:28 INFO - 1707 INFO TEST-START | dom/serviceworkers/test/test_serviceworker_interfaces.html
[task 2019-04-26T10:49:28.451Z] 10:49:28 INFO - <snipped 29 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>
[task 2019-04-26T10:49:28.451Z] 10:49:28 INFO - Buffered messages logged at 10:49:20
[task 2019-04-26T10:49:28.451Z] 10:49:28 INFO - 1708 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface Error to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

[task 2019-04-26T10:49:28.486Z] 10:49:28 INFO - 1806 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface ServiceWorker to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1807 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface ServiceWorkerRegistration to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - Buffered messages finished
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1808 INFO TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/test_serviceworker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - setupSW/window.onmessage@dom/serviceworkers/test/test_serviceworker_interfaces.html:31:9
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1809 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface SubtleCrypto to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1810 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface TextDecoder to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.487Z] 10:49:28 INFO - 1811 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface TextEncoder to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1812 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface URL to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1813 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface URLSearchParams to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1814 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WebSocket to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1815 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WindowClient to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.488Z] 10:49:28 INFO - 1816 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WorkerLocation to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1817 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WorkerNavigator to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1818 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: Atomics should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1819 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: SharedArrayBuffer should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1820 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushEvent should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1821 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushManager should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1822 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushMessageData should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1823 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushSubscription should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1824 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: PushSubscriptionOptions should NOT be defined on the global scope
[task 2019-04-26T10:49:28.489Z] 10:49:28 INFO - 1825 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | 0 === 0: The following interface(s) are not enumerated:
[task 2019-04-26T10:49:28.490Z] 10:49:28 INFO - 1826 INFO TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | The service worker should be unregistered successfully
[task 2019-04-26T10:49:28.490Z] 10:49:28 INFO - 1827 INFO TEST-OK | dom/serviceworkers/test/test_serviceworker_interfaces.html | took 269ms

I was unaware I had to update the mochitests. Updating now.

Flags: needinfo?(etoop)
Summary: Perma [tier2] Intermittent test_serviceworker_interfaces.html | test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window? → Perma [tier2] test_serviceworker_interfaces.html | test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface StorageManager to all webpages as a property on the window?
Whiteboard: [stockwell disable-recommended] → [stockwell needswork]
Whiteboard: [stockwell disable-recommended] → [stockwell needswork]

Hi Emily, are there any updates here?

Flags: needinfo?(etoop)

I'm trying to update the test such that it only runs for GeckoView and not for Fennec, but so far haven't found the right set of flags to switch off only Fennec.

Flags: needinfo?(etoop)

We want to start exposing the storage manager through GeckoView app, but continue not exposing it in Fennec. To enable this a new entry type for Fennec only (different from generic Android) is added to allow us to continue to exclude Fennec from the tests while enabling the tests for other Android builds.

Assignee: nobody → etoop
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [stockwell disable-recommended]

Emily, your patch got a review+, can we land it?

Flags: needinfo?(etoop)
Pushed by etoop@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a3c75d8e68a
Enable GV StorageManager testing in Mochitests. r=asuth

Queued for landing.

Flags: needinfo?(etoop)

https://hg.mozilla.org/mozilla-central/rev/6a3c75d8e68a

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: