1547162 - Remove the "-moz" prefix for column properties in imported css-multicol tests

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P5)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

The column properties in the imported css test in layout/reftests/w3c-css/received/css-multicol are auto-prefixed "-moz" by import-test.py in https://searchfox.org/mozilla-central/rev/75294521381b331f821aad3d6b60636844080ee2/layout/reftests/w3c-css/import-tests.py#41-52

We now support standard column properties, the "-moz" prefix shouldn't be needed.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Removing "-moz" prefix for column properties from the tests can fix multicol-span-000.xht because <div id="-moz-column-span">123456</div> is incorrectly replaced with <div id="-moz-column-span">123456</div>, which fails to get the style in div#column-span {}.

https://searchfox.org/mozilla-central/rev/197210b8c139b64f642edaa3336d26b9c1761568/layout/reftests/w3c-css/received/css-multicol/multicol-span-000.xht#44-48,61

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1547162 Part 1 - Remove unused variables and imports in import-test.py.

This is discovered by running "flake8 import-tests.py" locally.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1547162 Part 2 - Remove all the column properties from gPrefixedProperties in import-tests.py.

Also, build gPrefixRegexp and replace lines only if gPrefixedProperties
is non-empty. Otherwise, the import tests are messed up due to bogus
gPrefixRegexp.

Depends on D30404

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1547162 Part 3 - Strip "-moz" prefix for all column properties in the received tests, and mark multicol-span-000-ref.xht pass.

multicol-span-000.xht passes because the id in

<div id="column-span">123456</div>

was incorrect replaced by "-moz-column-span". Strip the "-moz" prefix
fixed it.

Except failures.list, other files was modified mechanically by running
import-tests.py against wpt commit
15f199c91a72b0d51bf0a12b3b77827ecb5051ff (the same commit in
received/import.log).

Depends on D30405

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82c216e530ea
Part 1 - Remove unused variables and imports in import-test.py. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/108d96d047cd
Part 2 - Remove all the column properties from gPrefixedProperties in import-tests.py. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/9c5a51b331c2
Part 3 - Strip "-moz" prefix for all column properties in the received tests, and mark multicol-span-000-ref.xht pass. r=dbaron

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/82c216e530ea
https://hg.mozilla.org/mozilla-central/rev/108d96d047cd
https://hg.mozilla.org/mozilla-central/rev/9c5a51b331c2