Closed Bug 1547182 Opened 5 months ago Closed 5 months ago

[remote-dbg-next] Add borders around warning and error messages

Categories

(DevTools :: about:debugging, defect, P1)

defect

Tracking

(firefox68 verified)

VERIFIED FIXED
Firefox 68
Tracking Status
firefox68 --- verified

People

(Reporter: jdescottes, Assigned: ogasidlo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [remote-debugging-reserve])

Attachments

(2 files)

We started using the same colors as the webconsole for about:debugging error and warning messages in Bug 1505126, but the fainter backgrounds can be hard to see when displayed in the sidebar, against our grey background.

Victoria suggested colors: red 80 at 16% and yellow 70 at 27%.

Also mentioned that we should have less line height in the message, and more spacing before the "Refresh Devices" button

Attached image mockups.png
Whiteboard: high-priority-reserve
Priority: -- → P3
Assignee: nobody → ogasidlo
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: high-priority-reserve → [remote-debugging-reserve]

Added borders for error / warning messages. Reduced line height in message body. Added more space between device list / message and refresh device button

Pushed by ogasidlo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de1a60c3fbf2
Added borders for error / warning messages r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Verified as fixed on Firefox Nightly 68.0a1 (2019-05-15) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.