1547275 - Failing performance mochitests should upload a profile of the failing run

Status: NEW

(Testing :: Mochitest, task, P3)

Description

[Florian Quèze [:florian]]

We have some intermittent failures on the browser/base/content/test/performance/ mochitests, and I think having a profile of the failed runs would help to diagnose what happened.

This is just an experiment at this point as I'm afraid the overhead induced by running the profiler might change the test's behavior.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1547275 - Upload a profile when a performance mochitest fails,

Comment 2

[alexander :surkov (:asurkov)]

Florian, it looks like a good improvement, and it'd be good to get it landed. Do you think it's ready for review?

Comment 3

[Florian Quèze [:florian]]

This is the try results I got: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b4e796acad6561f20eb912caed62d40ba46cf38

They show OOM crashes on Windows 32 bit.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 5

[Julien Wajsberg [:julienw]]

Hey Nazim, is that part of the bugs you're working on? Maybe you could find the right components or even duplicate to another existing issue?

Comment 6

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

My current task is about improving the performance tests with the profiler. This looks like an interesting request as well but not about the performance testing. We should probably finish it. Not sure if I can work on it now, but I will keep it in my stack.

Comment 7

[Florian Quèze [:florian]]

(In reply to alexander :surkov (:asurkov) from comment #2)

Florian, it looks like a good improvement, and it'd be good to get it landed. Do you think it's ready for review?

The reason why I didn't finish this patch is that profiler overhead (or other profiler issues) interfered with running the tests (eg. comment 3). If we can make the profiler overhead low enough, I would like us to do this for the entire mochitest test suite, and not just performance mochitests :-).