Closed Bug 1547334 Opened 6 months ago Closed 5 months ago

Show logpoint icon in console

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: davidwalsh, Assigned: davidwalsh)

Details

Attachments

(2 files)

I'd like to be able to easily identify console logs that come from specifically the logpoint feature of the debugger; I fear without some type of marker that they could get lost in other console.log noise.

Type: defect → enhancement
Priority: -- → P3
Attached image Log Point.svg

Tweaked design at 12px for the "breakpoint" icon:
https://www.figma.com/file/TH1VwPkEzM0XTT7VCdrK2BJh/Console-Icons

Not sure which we want to use.
I like the one with the 1px edge and ~20% opacity fill (middle).
Victoria, any preference?

SVG for middle and bottom row would look like:

<!-- This Source Code Form is subject to the terms of the Mozilla Public
   - License, v. 2.0. If a copy of the MPL was not distributed with this
   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 12" width="12" height="12">
  <path fill="context-fill" fill-opacity=".2" stroke="context-fill" stroke-linejoin="round" d="M.5 9V3c0-.83.67-1.5 1.5-1.5h5.05a.5.5 0 0 1 .38.17L11.33 6l-3.9 4.33a.5.5 0 0 1-.38.17H2A1.5 1.5 0 0 1 .5 9z"/>
</svg>

(The bottom one is the same, with fill-opacity=".5".)

The top row icon with its 1.5px stroke would be:

<!-- This Source Code Form is subject to the terms of the Mozilla Public
   - License, v. 2.0. If a copy of the MPL was not distributed with this
   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 12" width="12" height="12">
  <path fill="context-fill" fill-opacity=".2" stroke="context-fill" stroke-width="1.5" stroke-linejoin="round" d="M.75 9V3c0-.69.56-1.25 1.25-1.25h5.05c.08 0 .14.03.19.08L10.99 6l-3.75 4.17a.25.25 0 0 1-.19.08H2C1.31 10.25.75 9.69.75 9z"/>
</svg>
Flags: needinfo?(victoria)
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/804d239e671b
Show logpoint icon in webconsole r=Harald
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee: nobody → dwalsh

(clearing needinfo - I like what you came up with!)

Flags: needinfo?(victoria)
You need to log in before you can comment on or make changes to this bug.