1547346 - Delete profile dialog buttons have incorrect text and are cut off

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: delete profile.png

Seen on Windows 10 at 250% DPI scaling in Nightly 20190426094913

Comment 1

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

This may actually be caused by bug 1538983, I got regression range:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a885e5f28d3141921d9235adfdd0b88552e507a2&tochange=63fcd49131d7303b868a34241024d4a72ed1aafc

and it seems that the cutoff happens at the same time as the button text becomes incorrect.

STR: Go to about:profiles and click Remove for a profile

Comment 2

[Brian Grinstead [:bgrins]]

I can reproduce on OSX as well. Outer HTML on the button shows no [label] attribute:

<xul:button xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" dlgtype="extra1" class="dialog-button"><xul:hbox class="box-inherit button-box" align="center" pack="center" flex="1" anonid="button-box"><xul:image class="button-icon"/><xul:label class="button-text"/></xul:hbox></xul:button>

Comment 3

[Brian Grinstead [:bgrins]]

Also, the button that's supposed to say "Don't delete files" is saying "OK" (the default button text).

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1547346 - Upgrade custom elements in dialog anonymous XBL content before accessing them

Comment 5

[Brian Grinstead [:bgrins]]

So I found what looks like a concerning existing bug when testing this. When doing about:profiles -> "Remove" even on a release build it seems like clicking "cancel" or "don't delete files" still seems to delete the profile. If I press escape to close the prompt it goes away without deleting.

Comment 6

[Andrew Swan [:aswan]]

Attachment: Bug 1547346 Don't double-insert inner content when <button> is cloned

Comment 7

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Clicking "Cancel" seems to not delete the profiles for me (before or after this bug). Could the dialog be confused about what button is being pressed? Maybe it cancels properly on Windows but not OSX?

Comment 8

[Brian Grinstead [:bgrins]]

(In reply to Adam Gashlin (he/him) [:agashlin] from comment #7)

Clicking "Cancel" seems to not delete the profiles for me (before or after this bug). Could the dialog be confused about what button is being pressed? Maybe it cancels properly on Windows but not OSX?

You are right, I just double checked and Cancel is safe. Can you check if "Don't delete files" deletes the profile anyway?

Comment 9

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

I checked, "Don't Delete Files" removes the profile from profiles.ini but doesn't delete the profile directory, "Delete Files" removes both, "Cancel" does neither. Though I had to go back to an older version to have the buttons shown correctly (./mach mozregression --repo=inbound --launch=a885e5f28d3141921d9235adfdd0b88552e507a2).

Comment 10

[Brian Grinstead [:bgrins]]

(In reply to Adam Gashlin (he/him) [:agashlin] from comment #9)

I checked, "Don't Delete Files" removes the profile from profiles.ini but doesn't delete the profile directory, "Delete Files" removes both, "Cancel" does neither. Though I had to go back to an older version to have the buttons shown correctly (./mach mozregression --repo=inbound --launch=a885e5f28d3141921d9235adfdd0b88552e507a2).

OK, thanks for checking. I think this was just some confusion on my part. Any chance you can confirm the reported visual issues on windows are fixed with https://phabricator.services.mozilla.com/D29062?

Comment 11

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Looks perfect on Windows, thanks! I tested that each button still does the right thing, as well.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/776c731d7c71
Upgrade custom elements in dialog anonymous XBL content before accessing them r=aswan

Comment 13

[Phabricator Automation]

Comment on attachment 9061097 [details]
Bug 1547346 Don't double-insert inner content when <button> is cloned

Revision D29063 was moved to bug 1547322. Setting attachment 9061097 [details] to obsolete.

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/776c731d7c71