1547374 - clang build warning for nsINode.cpp using GetPresContext without definition ("Document.h:1274:25: warning: inline function 'mozilla::dom::Document::GetPresContext' is not defined [-Wundefined-inline]")

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Daniel Holbert [:dholbert]]

I noticed this build warning go by in a build today:

 0:20.82 ../../dist/include/mozilla/dom/Document.h:1274:25: warning: inline function 'mozilla::dom::Document::GetPresContext' is not defined [-Wundefined-inline]
 0:20.82   inline nsPresContext* GetPresContext() const;
 0:20.82                         ^
 0:20.82 /scratch/work/builds/mozilla-central/mozilla/dom/base/nsINode.cpp:1020:45: note: used here
 0:20.82   RefPtr<nsPresContext> context = document->GetPresContext();

Trivial fix -- nsINode.cpp needs to include DocumentInlines.h to provide this function.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1547374: Give nsINode.cpp an include for DocumentInlines.h (to provide e.g. inline definition for GetPresContext()). r?mccr8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/120e27d9bb9e
Give nsINode.cpp an include for DocumentInlines.h (to provide e.g. inline definition for GetPresContext()). r=mccr8

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/120e27d9bb9e