1547395 - Linux64 devedition builds should use 3-tier PGO

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Michael Shal [:mshal]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1516114#c30 through https://bugzilla.mozilla.org/show_bug.cgi?id=1516114#c32

Comment 1

[Mike Hommey [:glandium]]

More generally, shouldn't the devedition builds be derived from the shippable ones?

Comment 2

[Tom Prince [:tomprince]]

(In reply to Mike Hommey [:glandium] from comment #1)

More generally, shouldn't the devedition builds be derived from the shippable ones?

As I said in Bug 1516114 comment 32, they should definitely be renamed shippable. I don't know enough about the differences in the mozconfigs to know whether any of them affect the compiled code. If they don't affect the compile code, it seems like it would be reasonable to change them to somehow repack the shippable build. However, that seems like it is probably enough work to be beyond the scope of this bug.

Comment 3

[Mike Hommey [:glandium]]

I think we have too many build types that are similar to each other and that is a footgun (change one, forget the others). We should create the devedition tasks by duplicating and tweaking the shippable tasks programmatically, or something along those lines. BTW, IIRC, there's been a bug on file for this for a long time.

Comment 4

[Tom Prince [:tomprince]]

(In reply to Mike Hommey [:glandium] from comment #3)

I think we have too many build types that are similar to each other and that is a footgun (change one, forget the others). We should create the devedition tasks by duplicating and tweaking the shippable tasks programmatically, or something along those lines.

I agree ... but we should make devedition builds 3-tier pgo in the meantime.

Comment 5

[Michael Shal [:mshal]]

Attachment: Bug 1547395 - Allow specific tasks in the use-pgo field; r?tomprince

Some groups of tasks need to share the same profile data. For example,
Android PGO builds and Android Nightly builds both use the
generate-profile-android-api-16/pgo task for profile data. Previously
this was done with a text substitution, but this is a bit hacky and
doesn't easily scale with different build types.

Allowing use_pgo to be a string means we can just directly point to the
generate-profile task that contains the profile data to be used in a PGO
build.

Comment 6

[Michael Shal [:mshal]]

Attachment: Bug 1547395 - Use 3-tier PGO for linux64-devedition builds; r?chmanchester

Depends on D29247

Comment 7

[Michael Shal [:mshal]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5f958da36ffd60615ffd225f612334e3c0eadfe&selectedJob=243050648

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7aa4980e921
Allow specific tasks in the use-pgo field; r=tomprince
https://hg.mozilla.org/integration/autoland/rev/2de8fcb8a341
Use 3-tier PGO for linux64-devedition builds; r=chmanchester

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b7aa4980e921
https://hg.mozilla.org/mozilla-central/rev/2de8fcb8a341