Linux64 devedition builds should use 3-tier PGO

RESOLVED FIXED in Firefox 68

Status

task
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: mshal, Assigned: mshal)

Tracking

unspecified
mozilla68

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

More generally, shouldn't the devedition builds be derived from the shippable ones?

(In reply to Mike Hommey [:glandium] from comment #1)

More generally, shouldn't the devedition builds be derived from the shippable ones?

As I said in Bug 1516114 comment 32, they should definitely be renamed shippable. I don't know enough about the differences in the mozconfigs to know whether any of them affect the compiled code. If they don't affect the compile code, it seems like it would be reasonable to change them to somehow repack the shippable build. However, that seems like it is probably enough work to be beyond the scope of this bug.

I think we have too many build types that are similar to each other and that is a footgun (change one, forget the others). We should create the devedition tasks by duplicating and tweaking the shippable tasks programmatically, or something along those lines. BTW, IIRC, there's been a bug on file for this for a long time.

(In reply to Mike Hommey [:glandium] from comment #3)

I think we have too many build types that are similar to each other and that is a footgun (change one, forget the others). We should create the devedition tasks by duplicating and tweaking the shippable tasks programmatically, or something along those lines.

I agree ... but we should make devedition builds 3-tier pgo in the meantime.

Some groups of tasks need to share the same profile data. For example,
Android PGO builds and Android Nightly builds both use the
generate-profile-android-api-16/pgo task for profile data. Previously
this was done with a text substitution, but this is a bit hacky and
doesn't easily scale with different build types.

Allowing use_pgo to be a string means we can just directly point to the
generate-profile task that contains the profile data to be used in a PGO
build.

Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7aa4980e921
Allow specific tasks in the use-pgo field; r=tomprince
https://hg.mozilla.org/integration/autoland/rev/2de8fcb8a341
Use 3-tier PGO for linux64-devedition builds; r=chmanchester
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.