Closed Bug 1547416 Opened 1 year ago Closed 1 year ago

Move nsIPresShell::ScrollAxis to PresShellForwards.h

Categories

(Core :: Layout, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

nsIPresShell::ScrollAxis can be used anywhere and if it's used by another class, it's nice for consistency and actually we do that. So, it should be in mozilla namespace and perhaps, PresShellForwards.h is a good place to move it rather than creating new header file.

nsIPresShell::ScrollAxis can be used anywhere and it's used by some
utils actually. So, it should be in mozilla namespace and perhaps,
PresShellForwards.h is a good place to move it rather than creating
new header file.

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/d89587999df1
Move nsIPresShell::ScrollAxis to PresShellForwards.h r=smaug
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Backout by ncsoregi@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/20d44dfc1b05
Backed out 2 changesets (bug 1547416, bug 1547418) for causing conflicts. a=backout
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/2258dc01bcd1
Move nsIPresShell::ScrollAxis to PresShellForwards.h r=smaug

Change relanded and conflict fixed.

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/90234f4c094d
Move nsIPresShell::ScrollAxis to PresShellForwards.h: correct conflict fix. a=bustage-fix
You need to log in before you can comment on or make changes to this bug.