1547560 - [css-grid-2] Unable to override column-gap value from parent when in a subgrid.

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P3)

Description

[Rachel Andrew]

I am using the latest treeherder build on OSX.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23100795152d2faa97305e678b57316a9058773a

I have this example: https://codepen.io/rachelandrew/pen/ROdovg

1. The parent grid has gap: 20px.
2. The grid item "d" has subgridded rows and columns with row-gap and column-gap set to 0.
3. The row-gap is correctly set to 0.
4. The column-gap remains at 20px.

As detailed in the examples in the specification, it should be possible to change the size of the gaps:

"Meanwhile, half the size of the difference between the subgrid’s gutters (row-gap/column-gap) and its parent grid’s gutters is applied as an extra layer of (potentially negative) margin to the items not at those edges. This extra layer of “margin” also accumulates through multiple levels of subgrids."

https://drafts.csswg.org/css-grid-2/#subgrid-item-contribution

Comment 1

[Mats Palmgren (inactive)]

Attachment: Bug 1547560 - [css-grid-2] Add subgrid gaps to its items contributions in track sizing and recompute the subgrid tracks size/position to center the subgrid gaps. r=dholbert

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81136d6972e8
[css-grid-2] Add subgrid gaps to its items contributions in track sizing and recompute the subgrid tracks size/position to center the subgrid gaps.  r=dholbert

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/81136d6972e8