1547619 - :-moz-use-shadow-tree-root pseudo-class code is wrong.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

The following code:

https://searchfox.org/mozilla-central/rev/66086345467c69685434dd1c5177b30a7511b1a5/servo/components/style/gecko/wrapper.rs#868

Matches even if the <symbol> element is not in the shadow tree.

It should also check self.parent_node().map_or(false, |p| p.is_shadow_root()) or such.

But I think we can get rid of the pseudo-class entirely and all the associated code for symbol frames now we use Shadow DOM for this stuff.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1547619 - Fix :-moz-svg-use-shadow-tree-root pseudo-class. r=violet

Turns out removing the pseudo-class and such ends up not being quite as trivial
as I initially thought, or possible at all, since the fact that the <symbol> is
a <symbol> is observable via selectors, added a test for that.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcb59a0c2c44
Fix :-moz-svg-use-shadow-tree-root pseudo-class. r=violet

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fcb59a0c2c44

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16711 for changes under testing/web-platform/tests